Enable hotreload#807
Open
schultek wants to merge 13 commits into
Open
Conversation
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Package Version ReportThe following packages have been updated: |
parlough
reviewed
Jun 2, 2026
parlough
left a comment
parlough
left a comment
Contributor
There was a problem hiding this comment.
Exciting!! I haven't tried this out yet, but some comments, suggestions, and questions:
| webSdkDir, | ||
| 'kernel', | ||
| flutterVersion.compareTo('3.32.0') >= 0 ? 'amd-canvaskit' : 'amd-canvaskit-sound', | ||
| flutterVersion.compareTo('3.32.0') >= 0 ? ddcSdkPrefix : '$ddcSdkPrefix-sound', |
Contributor
There was a problem hiding this comment.
Slightly unrelated, but I guess we can remove this (and related) handling now. The package's SDK constraint requires Dart 3.8 or later, so Flutter 3.32 or later is required anyway.
Owner
Author
There was a problem hiding this comment.
I'll keep it just a bit longer, but yes then I will remove it.
Comment on lines
+368
to
+383
| // Add DDC Library Bundle defines. | ||
| if (usesDdcLibraryBundles) ...[ | ||
| '--define=build_web_compilers:ddc=ddc-library-bundle=true', | ||
| '--define=build_web_compilers:sdk_js=ddc-library-bundle=true', | ||
| '--define=build_web_compilers:entrypoint=ddc-library-bundle=true', | ||
| '--define=build_web_compilers:entrypoint_marker=ddc-library-bundle=true', | ||
| ], | ||
|
|
||
| // Add Web Hot Reload defines. | ||
| if (reloadConfig == ReloadConfiguration.hotReload) ...[ | ||
| '--define=build_web_compilers:sdk_js=web-hot-reload=true', | ||
| '--define=build_web_compilers:entrypoint=web-hot-reload=true', | ||
| '--define=build_web_compilers:entrypoint_marker=web-hot-reload=true', | ||
| '--define=build_web_compilers:ddc=web-hot-reload=true', | ||
| '--define=build_web_compilers:ddc_modules=web-hot-reload=true', | ||
| ], |
Contributor
There was a problem hiding this comment.
Should all of these only be added if the compiler is dartdevc?
| logger.write('Starting web compilers...', tag: Tag.cli, progress: ProgressState.running); | ||
| logger.write('Starting web compiler...', tag: Tag.cli, progress: ProgressState.running); | ||
|
|
||
| final compiler = useWasm |
Contributor
There was a problem hiding this comment.
Consider changing this to a private enum, then any conditional handling can validate you handled each case and spelling mistakes are avoided.
Owner
Author
|
@Markzipan When testing this with and Do you know anything about this? |
The following packages have been updated: jaspr_riverpod : 0.4.5 -> 0.4.6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables client-side hotreload in Jaspr
CC @Markzipan
Type of Change
Ready Checklist
the semantic_changelog format.
///).