Respect pluralize_table_names option when creating views#459
Open
flanger001 wants to merge 1 commit intoscenic-views:mainfrom
Open
Respect pluralize_table_names option when creating views#459flanger001 wants to merge 1 commit intoscenic-views:mainfrom
flanger001 wants to merge 1 commit intoscenic-views:mainfrom
Conversation
Author
|
@derekprior What do you think of this approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #312
As a preamble, I have followed all the steps in
CONTRIBUTING.mdand have attempted to change the smallest number of lines of code possible.This PR allows Scenic to respect the
pluralize_table_namesoption when creating views. Formerly, ifpluralize_table_nameswas set tofalse, Scenic would still create a pluralized view and migration file, e.g.:The generator command:
Outputs:
db/migrate/TIMESTAMP_create_searches.rbdb/views/searches_v01.sql.Now, with the aforementioned config, this is our output:
db/migrate/TIMESTAMP_create_search.rbdb/views/search_v01.sql.Updating migrations works as well:
./bin/rails generate scenic:view searcha second time will output:db/migrate/TIMESTAMP_update_search_to_version_2.rbdb/views/search_v02.sql.