Configurable root path#306
Closed
tomasc wants to merge 3 commits intoscenic-views:mainfrom
Closed
Conversation
2 tasks
Contributor
|
@tomasc how would this work in cases where both the engine and the app itself want to use Scenic? |
|
I would think you need two config files for that, one in the engine and one at the app level. Or you could add a env var or argument to override the "default" path. |
Contributor
|
The configuration is currently a singleton, so I don't think that would work |
Contributor
|
We have a number of proposed changes (see: view-paths ) that cover this same functionality. I think #237 is closest to something we would consider merging in that covers multiple use cases. Swapping one static path for another would solve some problems but create others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for configuration of the root path, where Scenic looks up its views:
The default value stays
Rails.root.This is a follow up to #237 (comment) and addresses #261.