Implement custom views path#298
Closed
DNA wants to merge 1 commit into
Closed
Conversation
Implement a configuration attribute the user can edit to change the default path where the view SQL files are generated
Contributor
|
We have a number of proposed changes (see: view-paths ) that cover this same functionality. I think #237 is closest to something we would consider merging in that covers multiple use cases. Swapping one static path for another would solve some problems but create others. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there!
Here at work we use two database adapters, SQL Server and SQLite (for quick tests before CI/CD). Since some syntax between those two are incompatible, we need to have two SQL files, and those can't live in the same directory.
The best solution we found was to add a configuration attribute to define the views path directory, so we can edit it inside Rails like that:
Since more people could benefit from this change, I've decided to open a PR.
Let me know if it's is OK or if I missed something 😃