Allows you to override the root path directly on a per-instance basis#287
Open
nathanpalmer wants to merge 3 commits intoscenic-views:mainfrom
Open
Allows you to override the root path directly on a per-instance basis#287nathanpalmer wants to merge 3 commits intoscenic-views:mainfrom
nathanpalmer wants to merge 3 commits intoscenic-views:mainfrom
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| # replace_view :engagement_reports, version: 3, revert_to_version: 2 | ||
| # | ||
| def replace_view(name, version: nil, revert_to_version: nil, materialized: false) | ||
| def replace_view(name, version: nil, revert_to_version: nil, materialized: false, root_path: Rails.root) |
There was a problem hiding this comment.
Lint/UnusedMethodArgument: Unused method argument - revert_to_version.
Metrics/LineLength: Line is too long. [108/80]
| # update_view :engagement_reports, version: 3, revert_to_version: 2 | ||
| # | ||
| def update_view(name, version: nil, sql_definition: nil, revert_to_version: nil, materialized: false) | ||
| def update_view(name, version: nil, sql_definition: nil, revert_to_version: nil, materialized: false, root_path: Rails.root) |
There was a problem hiding this comment.
Metrics/ParameterLists: Avoid parameter lists longer than 5 parameters. [6/5]
Lint/UnusedMethodArgument: Unused method argument - revert_to_version.
Metrics/LineLength: Line is too long. [128/80]
| # SQL | ||
| # | ||
| def create_view(name, version: nil, sql_definition: nil, materialized: false) | ||
| def create_view(name, version: nil, sql_definition: nil, materialized: false, root_path: Rails.root) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [104/80]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps in situations where you are creating or updating views from within a Rails engine. By adding the
root_pathto the statement it will be able to correctly find the file.The
, root_path: Database::Engine.rootis the part that is manually added. I didn't find any method of autodetecting the rails engine so this would have to be manually added after generating the migration.Solves the issue I brought up in #261
create_view
update_view
replace_view