Conversation
tmacro
force-pushed
the
user/tmacro/bucket_notifications_sasl_plain
branch
from
660d293 to
2fdbaeb
Compare
tmacro
force-pushed
the
user/tmacro/bucket_notifications_sasl_plain
branch
from
2fdbaeb to
16c56e0
Compare
tcarmet
approved these changes
Jul 16, 2025
| TOPICS_TO_CREATE: backbeat-lifecycle-bucket-tasks backbeat-lifecycle-object-tasks backbeat-bucket-notification | ||
| CREATE_NOTIFICATION_PATHS: 'true' | ||
| ZOOKEEPER_ENDPOINT: 127.0.0.1:2181/backbeat | ||
| depends_on: |
Contributor
There was a problem hiding this comment.
Shouldn't it depend on kafka or zookeeper as well?
Contributor
There was a problem hiding this comment.
I saw later on, that the setup scripts waits for kafka. If we follow a kube approach to it, we shouldn't care about depends so pretty much optional.
Contributor
Author
There was a problem hiding this comment.
It would be nice to flesh out the healthchecks a bit so that depends could be used to actually wait for kafka. I haven't figured out a good way to do it yet though.
Co-authored-by: Thomas Carmet <[email protected]>
tmacro
force-pushed
the
user/tmacro/bucket_notifications_sasl_plain
branch
from
b6e6881 to
7697621
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.