Skip to content

ci: update GitHub Actions to Node 24 runtime (Node 20 deprecation) #4879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JBWatenbergScality wants to merge 2 commits into from
Closed

ci: update GitHub Actions to Node 24 runtime (Node 20 deprecation) #4879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06888e4
ci: update GitHub Actions to Node 24 runtime (Node 20 deprecation)
JBWatenbergScality Apr 14, 2026
7072aed
ci(build): bump docker/login-action from v2 to v4
JBWatenbergScality Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/build-devcontainer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ jobs:
- name: Checkout
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4
- name: Login to the registry
uses: docker/login-action@v3
uses: docker/login-action@v4
Copy link
Copy Markdown
Contributor

@claude claude Bot Apr 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docker/login-action@v2 in .github/workflows/build.yaml:73 was missed by this PR and still runs on Node 20. It should be updated to @v4 for consistency with the other workflow files.

— Claude Code

with:
registry: ghcr.io
username: ${{ github.repository_owner }}
Expand All @@ -30,7 +30,7 @@ jobs:
# NOTE: We only skip this and not the full Job
# otherwise step that "need" it will not be started
if: ${{ ! inputs.skip }}
uses: docker/build-push-action@v6
uses: docker/build-push-action@v7
with:
context: .devcontainer/
push: true
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build-shell-ui.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
with:
ref: ${{ inputs.ref }}
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4
- name: Compute shell-ui version
run: |
source VERSION
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ jobs:
artifact-link: ${{ steps.upload.outputs.link }}
steps:
- name: Login to Docker Hub
uses: docker/login-action@v2
uses: docker/login-action@v4
with:
username: ${{ secrets.DOCKERHUB_LOGIN }}
password: ${{ secrets.DOCKERHUB_PASSWORD }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/pre-merge.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ jobs:
- name: Checkout
uses: actions/checkout@v6
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4
- name: Install node
uses: actions/setup-node@v6
with:
Expand Down Expand Up @@ -446,13 +446,13 @@ jobs:
ADD service /usr/share/nginx/html
EOF
- name: Login to Registry
uses: docker/login-action@v3
uses: docker/login-action@v4
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- uses: docker/build-push-action@v6
- uses: docker/build-push-action@v7
with:
push: true
file: Dockerfile
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:
# See: https://github.com/actions/checkout/issues/882
ref: ${{ github.ref }}
- name: Set up Docker Buildx
uses: docker/setup-buildx-action@v3
uses: docker/setup-buildx-action@v4

# Retrieve Shell UI image from the build, load it and compute version
- name: Retrieve artifacts url
Expand Down Expand Up @@ -125,7 +125,7 @@ jobs:

# Push image to the registry
- name: Login to the registry
uses: docker/login-action@v3
uses: docker/login-action@v4
with:
registry: ${{ env.REGISTRY_HOST }}
username: ${{ github.repository_owner }}
Expand All @@ -143,7 +143,7 @@ jobs:
git tag -l --format='%(contents)' "${{ env.SHELL_UI_VERSION }}" | tail -n +4 | tee -a $GITHUB_OUTPUT
echo "EOF" >> $GITHUB_OUTPUT

- uses: softprops/action-gh-release@v2
- uses: softprops/action-gh-release@v3
if: inputs.is_production
with:
name: Metalk8s ${{ env.SHELL_UI_VERSION }}
Expand Down
Loading