-
Notifications
You must be signed in to change notification settings - Fork 0
SignatureDoesNotMatch for object keys with special characters in cloudserverclient #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4b7eeac
Prevent SigV4 double URI-encoding of path parameters
maeldonn 534f3e2
Bump fast-xml-parser from 4.5.3 to 4.5.6
maeldonn 2a0275a
Bump ts-jest from 29.4.5 to 29.4.9
maeldonn 064c899
Bump flatted from 3.3.3 to 3.4.2 via resolutions
maeldonn 6ca42b5
Bump package.json to 1.0.8
maeldonn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,66 @@ | ||
| import { PutObjectCommand } from '@aws-sdk/client-s3'; | ||
| import { GetMetadataCommand } from '../src/clients/backbeatRoutes'; | ||
| import { GetFailedObjectCommand } from '../src/clients/proxyBackbeatApis'; | ||
| import { createTestClient, testConfig } from './testSetup'; | ||
| import { describeForBackbeatSetup } from './testHelpers'; | ||
|
|
||
| const specialCharKeys = [ | ||
| { name: 'spaces', key: 'file with spaces.txt' }, | ||
| { name: 'parentheses', key: 'file(1).txt' }, | ||
| { name: 'exclamation', key: 'important!.txt' }, | ||
| { name: 'single quote', key: "it's a file.txt" }, | ||
| { name: 'asterisk', key: 'wild*card.txt' }, | ||
| { name: 'plus sign', key: 'a+b.txt' }, | ||
| { name: 'multiple spaces', key: 'Screenshot from 2026-04-14 17-59-19.png' }, | ||
| { name: 'unicode', key: 'données café.txt' }, | ||
| { name: 'equals sign', key: 'key=value.txt' }, | ||
| { name: 'at sign', key: 'user@domain.txt' }, | ||
| { name: 'hash', key: 'section#1.txt' }, | ||
| { name: 'percent literal', key: 'file%20already-encoded.txt' }, | ||
| { name: 'mixed special chars', key: 'file (1) copy!.txt' }, | ||
| ]; | ||
|
|
||
| describe('SigV4 signing with special character keys', () => { | ||
| const { backbeatRoutesClient, proxyBackbeatApisClient, s3client } = createTestClient(); | ||
|
|
||
| beforeAll(async () => { | ||
| await Promise.all(specialCharKeys.map(({ key }) => | ||
| s3client.send(new PutObjectCommand({ | ||
| Bucket: testConfig.bucketName, | ||
| Key: key, | ||
| Body: 'test', | ||
| })), | ||
| )); | ||
| }); | ||
|
|
||
| describe('BackbeatRoutesClient', () => { | ||
| it.each(specialCharKeys)( | ||
| 'should not double-encode $name in path', | ||
| async ({ key }) => { | ||
| const result = await backbeatRoutesClient.send( | ||
| new GetMetadataCommand({ | ||
| Bucket: testConfig.bucketName, | ||
| Key: key, | ||
| }), | ||
| ); | ||
| expect(result.Body).toBeDefined(); | ||
| }, | ||
| ); | ||
| }); | ||
|
|
||
| describeForBackbeatSetup('ProxyBackbeatApisClient', () => { | ||
| it.each(specialCharKeys)( | ||
| 'should not double-encode $name in path', | ||
| async ({ key }) => { | ||
| const result = await proxyBackbeatApisClient.send( | ||
| new GetFailedObjectCommand({ | ||
| Bucket: testConfig.bucketName, | ||
| Key: key, | ||
| VersionId: testConfig.versionID, | ||
| }), | ||
| ); | ||
| expect(result.$metadata.httpStatusCode).toBe(200); | ||
| }, | ||
| ); | ||
| }); | ||
| }); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.