Improvement/CLDSRV-825 drop ceph support#6097
Conversation
Hello benzekrimaha,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
4365d2c to
178412f
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
a4528f1 to
ef671c1
Compare
|
LGTM |
a373210 to
ccb9542
Compare
Branches have divergedThis pull request's source branch To avoid any integration risks, please re-synchronize them using one of the
Note: If you choose to rebase, you may have to ask me to rebuild |
|
@francoisferrand Thanks for the careful review — I agree with your point that removing tests without removing related code would leave us with untested legacy behavior. |
| delete caps.locationTypeCephRadosGW; | ||
| delete caps.cephIngestLocation; |
There was a problem hiding this comment.
this was an earlier comment, we need to keep these!
cloudserver will not support ceph anymore, so we don't want to advertise that we still support it
this is not "ceph-specific" logic, this is logic which was introduced earlier on purpose to correctly report that we DO NOT support ceph anymore. So it must be kept.
yes, as discussed on Monday we need to check in Arsenal as well : where the actual specifics of each (data) backend are implemented |
7b8ef8e to
46e4bbc
Compare
c5a99b1 to
616fab2
Compare
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command: Alternatively, the |
616fab2 to
f0acfc4
Compare
|
LGTM |
|
|
||
| const describeSkipIfNotMultipleOrCeph = config.backends.data !== 'multiple' | ||
| ? describe.skip : describe.skip; | ||
|
|
There was a problem hiding this comment.
The objectPutCopyPartAzure.js file has a blank line left behind after removing the old local describeSkipIfNotMultipleOrCeph definition (line 23-24). Cosmetic, not a blocker.
— Claude Code
|
LGTM |
Drop the Ceph CI service, helper scripts, and dedicated test location config now that CloudServer no longer supports Ceph RadosGW. Remove the CI_CEPH runtime overrides from Config so location constraints follow the normal validation path, and keep report capabilities from advertising Ceph support even if an external config still provides those legacy flags. Issue: CLDSRV-825
Delete the Ceph-only Mocha helpers and replace Ceph-conditioned skips with the regular multiple-backend guards so the remaining suites run for supported backends. Clean up Ceph-specific expected errors, comments, and fixture references from functional and multiple-backend tests while preserving the generic S3 behavior coverage. Issue: CLDSRV-825
Adapt the range functional test to the SDK v3 response body API by materializing the returned byte array before writing it to disk. Return uploaded part responses so CompleteMultipartUpload receives the expected ETags, and tolerate NoSuchUpload during cleanup after the upload has already completed. Issue: CLDSRV-825
Update the Arsenal dependency to 8.4.1 so CloudServer consumes the backend capability changes that complete the Ceph support removal. Refresh yarn.lock for the new Arsenal revision and its hdclient dependency requirement. Issue: CLDSRV-825
f0acfc4 to
f64bab2
Compare
|
LGTM |
|
/approve |
Queue build failedThe corresponding build for the queue failed:
Remove the pull request from the queue
|
|
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-825. Goodbye benzekrimaha. |
Issue: CLDSRV-825