(PTFE-2505) Cascade not handle rightly three digit branch#252
Merged
matthiasL-scality merged 1 commit intomainfrom Jul 11, 2025
Merged
(PTFE-2505) Cascade not handle rightly three digit branch#252matthiasL-scality merged 1 commit intomainfrom
matthiasL-scality merged 1 commit intomainfrom
Conversation
5ea58ad to
4cea012
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 89.01% 89.01%
=======================================
Files 75 75
Lines 10028 10028
=======================================
Hits 8926 8926
Misses 1102 1102
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
eb9f588 to
c2d345e
Compare
c2d345e to
873eb52
Compare
charlesprost
approved these changes
Jul 11, 2025
Contributor
|
Would have been nice to see a more high level test of this situation, just like you did for other scenarios. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Micro version are not rightly get when compare with two digit branch (when micro version is 0)