Create deployments in component repos to visualize integration#2375
Create deployments in component repos to visualize integration#23758 commits merged intodevelopment/2.14from
Conversation
14840db to
cc68501
Compare
Hello francoisferrand,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
DarkIsDude
left a comment
There was a problem hiding this comment.
Do you have some screenshot about the result to add in the PR ?
DarkIsDude
left a comment
There was a problem hiding this comment.
Are you sure we need all this complexity ? Can we just create a simple deployment when the CI is green without transient / not success state ?
7272c7e to
40306ae
Compare
Transient is for reporting status on PRs : i.e. when we open zenko PR (with bumps), it would create deployments in other repos immediately (before PR is merged!) and this is "show" in the component (head or even PR) that integration succeeded OR failed. Once merged on development branches or released, indeed should only post successful deployments. So yes, we need something. And AFAIK it the complexity should be pretty limited, should not have much impact on dev... Worse case it is a useless experiment, and we will remove it. |
e8876d6 to
ba80646
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
The following reviewers are expecting changes from the author, or must review again: |
|
maeldonn
left a comment
There was a problem hiding this comment.
LGTM
@DarkIsDude I agree with Francois, the transient flow is the main value of this feature. Worth keeping.
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
3cd0a74 to
ec535e7
Compare
|
/approve |
3727d6c to
af1f90c
Compare
In order to show integration status, create deployments (in each component!) when they are integrated. PR builds create transient deployments, while a new post-merge step Issue: ZENKO-5132
To reduce noise, publish (transient) deployments only for components which are updated by the PR. In post-merge, we always publish deployments though: as it really indicates the componet is used (and we keep updating the same deployment so not much noise). Issue: ZENKO-5132
It is not available in github runners, so use yq to convert to JSON instead. Issue: ZENKO-5132
Name of deployment is now <branch name>@<target branch number>, to know precisely what the transient build is, but also where it would land. Issue: ZENKO-5132
When computing diff (for transient PR), consider only the changes introduced by this PR. Issue: ZENKO-5132
af1f90c to
0dd99d2
Compare
Build failedThe build for commit did not succeed in branch improvement/ZENKO-5132 The following options are set: approve |
a265da5
Create deployment in other repos
In order to show integration status, create deployments (in each
component!) when they are integrated.
This will allow visualizing directly in components where/when they are integrated in Zenko.
Exemples on a ZKOP PR:

Exemple on repo:

Issue: ZENKO-5132