Enable sc:compile for stdlib package scala.collection#25838
Merged
SethTisue merged 1 commit intoApr 21, 2026
Conversation
…ude sub-packages.
bishabosha
reviewed
Apr 17, 2026
| * List(1) | ||
| * ``` | ||
| * | ||
| * ```scala sc:compile |
Member
There was a problem hiding this comment.
is this an improvement? perhaps the sc:compile mode should support REPL session syntax
Member
There was a problem hiding this comment.
well, that would be nice, but I think we should merge this anyway, rather than wait for a speculative future improvement. I rather liked the REPL version, but this way seems approximately as good to me, and it gets us the checking now.
SethTisue
approved these changes
Apr 17, 2026
bishabosha
approved these changes
Apr 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added sc-compile to classes under scala.collection, but does not include sub-packages.