Fix warning about -Xcheck-macros#25757
Merged
bishabosha merged 2 commits intoscala:mainfrom Apr 14, 2026
Merged
Conversation
bishabosha
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussing with @bishabosha and further investigating, I realized the warning I introduced yesterday in #25750 is wrong.
Code generated by macros is actually checked, even without
-Xcheck-macros, here:scala3/compiler/src/dotty/tools/dotc/inlines/Inliner.scala
Lines 966 to 967 in 20fc4c7
The errors I am missing are due to these checks being run without an expected type, which I'll try to address separately (#25756).
This PR reverts #25750, but still rephrase to avoid saying these are runtime checks.