Use precise type for x in case x @ (_: A, _: B)#25734
Open
SolalPirelli wants to merge 3 commits intoscala:mainfrom
Open
Use precise type for x in case x @ (_: A, _: B)#25734SolalPirelli wants to merge 3 commits intoscala:mainfrom
x in case x @ (_: A, _: B)#25734SolalPirelli wants to merge 3 commits intoscala:mainfrom
Conversation
SolalPirelli
added
the
needs-squashing
Contributor
Author
|
@noti0na1 how bad do you think this is? it works and I have no other idea but I don't like it that much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25544
I'm not a big fan of this, but it works, so it's a good first step in getting someone to tell me why it's actually bad and what should be done instead :)
How much have you relied on LLM-based tools in this contribution?
as much as som-snytt does
How was the solution tested?
issue regression test