Replace decimal year conversions with julian year conversions.#382
Open
sblunt wants to merge 5 commits into
Open
Replace decimal year conversions with julian year conversions.#382sblunt wants to merge 5 commits into
sblunt wants to merge 5 commits into
Conversation
semaphoreP
reviewed
Jun 16, 2026
semaphoreP
left a comment
semaphoreP
left a comment
Collaborator
There was a problem hiding this comment.
I think it generally looks good to me. Did you have a chance to run an HGCA orbit fit to see if it matches previous results?
| """ | ||
|
|
||
| def __init__(self, epochs_mjd, alpha0, delta0, alphadec0_epoch=1991.25): | ||
| def __init__(self, epochs_mjd, alpha0, delta0, alphadec0_epoch=Time("J1991.25", format="jyear_str").jyear): |
Collaborator
There was a problem hiding this comment.
probably shouldn't initialize a keyword with a non-primitive type for python reasons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #372. This doesn't have any big impact on the Hipparcos IAD refitting, but maybe it affects things on longer timescales (i.e. hipparcos-gaia). Will continue to investigate.