Skip to content

fix: AsyncResult.as_list returns a list of task IDs #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sanjays2402 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: AsyncResult.as_list returns a list of task IDs #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion celery-stubs/result.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ class AsyncResult(ResultBase, Generic[_R_co]):
def maybe_reraise(
self, propagate: bool = ..., callback: Callable[..., Any] | None = ...
) -> None: ...
def as_list(self) -> list[AsyncResult[Any]]: ...
def as_list(self) -> list[str]: ...
def wait(
self,
timeout: float | None = ...,
Expand Down
4 changes: 4 additions & 0 deletions tests/test_celery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,3 +408,7 @@ def test_djangotask(task: DjangoTask[[int, int], Any]) -> None:

def test_abortabletask(task: AbortableTask[[], None]) -> None:
task.is_aborted()


def test_async_result_as_list(result: AsyncResult[None]) -> None:
assert_type(result.as_list(), list[str])