dev: update pre-commit hooks to match ci - #229
Merged
Merged
Conversation
Adds the ty type checker to the README, linting script, and pre-commit hooks. This matches the requirements of the ci gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While turning around the last PR, I stubbed my toe on
tychecks running in CI but not in pre-commit. PR #212 looks like it added the check, but not the local devtools or mention in the readme. This PR adds the ty type checker to the README, linting script, and pre-commit hooks, matching the requirements of the ci gate.I had this in my branches, but am a little ambivalent about further cementing
tyas a supported type checker, because I ran into a confusing bug while using it. I compromised by writing up the problem, and being embarrassed about the wall of text. Can't win I guess.