fix SIGSEGV when store config was found but isn't readable - #34
Merged
Conversation
SKevo18
commented
Jun 13, 2026
| @@ -0,0 +1,14 @@ | |||
| <?php | |||
Contributor
Author
There was a problem hiding this comment.
would break tests otherwise:
could not parse fixture//magento2/configs/empty.php, missing user or db name
open /do/not/exist: no such file or directory
--- FAIL: TestDiscoverStores (0.05s)
store_test.go:24:
Error Trace: store_test.go:24
Error: "[%!s(*gocommerce.Store=&{fixture/discovery/applications/123456789/public_html 0x1016eec60 0x1d8fb903abe8})]" should have 2 item(s), but has 1
Test: TestDiscoverStores
panic: runtime error: index out of range [1] with length 1 [recovered, repanicked]
the configs should never be empty anyways(?), so I added a minimal placeholder
gwillem
approved these changes
Jun 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.