[ruby] Update rubocop-rails 2.34.3 → 2.35.2 (minor)

[depfu]

Here is everything you need to know about this update. Please take a good look at what changed and the test results before merging this pull request.

What changed?

✳️ rubocop-rails (2.34.3 → 2.35.2) · Repo · Changelog

Release Notes

2.35.2

Bug fixes

• #1625: Fix false positives in Rails/StrongParametersExpect when using collection methods (such as delete, keys, merge, slice, dig, fetch, or transform_values) on params[:key], as well as block-style calls such as params[:key].each { ... } or params[:key].map(&:to_s). (@koic)
• #1627: Fix false positives in Rails/StrongParametersExpect for usages like params[:key].try(:method) and params[:key].try!(:method). (@nicholasdower)

2.35.1

Bug fixes

• #1616: Fix false positives in Rails/StrongParametersExpect when using nil-safe conversion methods such as to_i, to_s, to_a, to_f, and to_h on params[:key]. (@koic)
• #1622: Fix false positives in Rails/StrongParametersExpect when using key-check methods such as key?, has_key?, include?, and member? on params[:key]. (@koic)
• #1620: Fix false positives in Rails/StrongParametersExpect when using type-check methods such as is_a?, kind_of?, and instance_of? on params[:key]. (@koic)

2.35.0

Bug fixes

• #1595: Fix a false negative for Rails/I18nLocaleTexts when using redirect_back_or_to with a flash message. (@55728)
• #1587: Fix false positives for Rails/Presence with operator methods like <<, =~, and others. (@eugeneius)
• #1586: Don't add unnecessary parentheses in Rails/Presence. (@eugeneius)
• #1602: Fix an error in Rails/SelectMap when .select appears inside a subquery in an argument. (@koic)
• #1604: Allow DatabaseTypeResolvable to fall back to an adapter configuration specified in a shared key. (@codergeek121)
• #1582: Fix a false negative where local was incorrectly treated as a known environment name when using == comparison in Rails/UnknownEnv. (@lovro-bikic)

Changes

• #1571: Add more detection patterns on Rails/ResponseParsedBody. (@r7kamura)
• #1583: Extend Rails/StrongParametersExpect to detect params[:key] in method calls and raising finder methods. (@koic)
• #1584: Add support for case statements to Rails/UnknownEnv. (@lovro-bikic)
• #1592: Fix false negative for != comparison in Rails/UnknownEnv. (@lovro-bikic)
• #1598: Use glob patterns compatible with Engine or Packwerk for cops targeting spec/ and test/ directories. (@y-yagi)

Does any of this look wrong? Please let us know.

Commits

See the full diff on Github. The new version differs by 48 commits:

• Cut 2.35.2
• Update Changelog
• Merge pull request #1626 from koic/fix_false_positives_for_rails_strong_parameters_expect_with_collection_methods
• [Fix #1625] Fix false positives in `Rails/StrongParametersExpect`
• Merge pull request #1627 from nicholasdower/try
• Fix false positives for try and try! in Rails/StrongParametersExpect
• Reset the docs version
• Cut 2.35.1
• Update Changelog
• Merge pull request #1624 from koic/fix_false_positives_for_rails_strong_parameters_expect_with_key_check_methods
• [Fix #1622] Fix false positives in `Rails/StrongParametersExpect`
• Merge pull request #1623 from koic/fix_false_positives_for_rails_strong_parameters_expect_with_type_check_methods
• [Fix #1620] Fix false positives in `Rails/StrongParametersExpect`
• Merge pull request #1616 from koic/fix_false_positives_in_rails_strong_parameters_expect
• [Fix #1618] Update the doc of `Rails/RedundantActiveRecordAllMethod`
• Fix false positives in `Rails/StrongParametersExpect`
• Reset the docs version
• Cut 2.35.0
• Update Changelog
• Fix `KeyError` when `shared` key has no `adapter` in `database.yml`
• Merge pull request #1605 from codergeek121/support-shared-key
• Merge pull request #1603 from koic/fix_an_error_in_rails_select_map
• Fix support for shared key in database.yml
• [Fix #1602] Fix an error in `Rails/SelectMap`
• Merge pull request #1597 from 55728/fix-i18n-locale-texts-redirect-back-or-to
• [Fix #1595] Fix a false negative for `Rails/I18nLocaleTexts` when using `redirect_back_or_to`
• Merge pull request #1598 from y-yagi/globs_cops_for_test
• Use glob patterns compatible with Engine or Packwerk for cops targeting `spec/` and `test/` directories
• Merge pull request #1591 from koic/make_rails_strong_parameters_expect_allow_presence
• Merge pull request #1592 from lovro-bikic/unknown-env-inequality-comparison
• Fix false negative for != comparison in Rails/UnknownEnv
• Make `Rails/StrongParametersExpect` allow `presence`
• Suppress RuboCop's offenses
• Merge pull request #1587 from eugeneius/presence_operator_methods
• Merge pull request #1586 from eugeneius/presence_parentheses
• Don't autocorrect operator methods in Rails/Presence
• Don't add unnecessary parentheses in Rails/Presence
• Merge pull request #1583 from koic/enhance_rails_strong_parameters_expect
• Make `Rails/StrongParametersExpect` aware of `params[:key]`
• Merge pull request #1584 from lovro-bikic/rails-unknown-env-case-support
• Add support for case statements to Rails/UnknownEnv
• Merge pull request #1582 from lovro-bikic/unknown-env-local-comparison
• Fix a false negative where 'local' was incorrectly treated as a known environment name when using == comparison in Rails/UnknownEnv
• Drop `prism_spec` from the default Rake task
• Merge pull request #1571 from r7kamura/response-parsed-body-html-method
• Use RuboCop RSpec 3.9.0 for development
• Merge pull request #1564 from r7kamura/requires-gem-compatibility-remove
• Reset the docs version

---

Depfu will automatically keep this PR conflict-free, as long as you don't add any commits to this branch yourself. You can also trigger a rebase manually by commenting with @depfu rebase.

All Depfu comment commands

@​depfu rebase

Rebases against your default branch and redoes this update

@​depfu recreate

Recreates this PR, overwriting any edits that you've made to it

@​depfu merge

Merges this PR once your tests are passing and conflicts are resolved

@​depfu cancel merge

Cancels automatic merging of this PR

@​depfu close

Closes this PR and deletes the branch

@​depfu reopen

Restores the branch and reopens this PR (if it's closed)

@​depfu pause

Ignores all future updates for this dependency and closes this PR

@​depfu pause [minor|major]

Ignores all future minor/major updates for this dependency and closes this PR

@​depfu resume

Future versions of this dependency will create PRs again (leaves this PR as is)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.32%. Comparing base (6dc9829) to head (615d028).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #5793      +/-   ##
===========================================
- Coverage    87.35%   87.32%   -0.03%     
===========================================
  Files         1479     1479              
  Lines        33582    33582              
  Branches      3553     3553              
===========================================
- Hits         29334    29324      -10     
- Misses        4227     4237      +10     
  Partials        21       21              

Flag	Coverage Δ
javascript	72.72% <ø> (ø)
ruby	87.33% <ø> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[StephenHulme]

@​depfu rebase