Feature/encrypted results#67
Conversation
…ypting peat_results, added file check to remove type error if not file / archive is specified
|
|
||
| from peat import results_crypto | ||
|
|
||
|
|
There was a problem hiding this comment.
I'd like a test that validates an encrypted zip file cannot be opened with normal zipfile or zip on command line. also some tests for the CLI arguments, executing workflow end-to-end (there are examples of this in https://github.com/sandialabs/PEAT/blob/main/tests/test_cli_commands.py
There was a problem hiding this comment.
also i know you're still working on this (thanks for opening a draft PR!), so if you're already working on more tests plz ignore :)
There was a problem hiding this comment.
Added some more tests, did you also want the documentation updated as well?
There was a problem hiding this comment.
oh yeah, documentation definitely needs to be updated! at least a blurb on what encrypted results are, how to use the feature, a few example use cases, and any limitations/caveats.
There was a problem hiding this comment.
would you like this in the operate.rst file or is there another location I might not be tracking?
There was a problem hiding this comment.
Yes, Operate makes the most sense
… pyfixtures to conftest
| [[package]] | ||
| name = "towncrier" | ||
| version = "25.8.0" | ||
| requires_python = ">=3.9" | ||
| summary = "Building newsfiles for your project." | ||
| dependencies = [ | ||
| "click", | ||
| "importlib-metadata>=4.6; python_version < \"3.10\"", | ||
| "importlib-resources>=5; python_version < \"3.10\"", | ||
| "jinja2", | ||
| "tomli; python_version < \"3.11\"", | ||
| ] | ||
| files = [ | ||
| {file = "towncrier-25.8.0-py3-none-any.whl", hash = "sha256:b953d133d98f9aeae9084b56a3563fd2519dfc6ec33f61c9cd2c61ff243fb513"}, | ||
| {file = "towncrier-25.8.0.tar.gz", hash = "sha256:eef16d29f831ad57abb3ae32a0565739866219f1ebfbdd297d32894eb9940eb1"}, | ||
| ] | ||
|
|
There was a problem hiding this comment.
Did you intend to remove this or was this a bad merge conflict?
I'm new to pdm.lock files so I don't know if this was auto generated or not.
There was a problem hiding this comment.
The lock file is auto-generated by PDM. Basically it's the full dependency chain. Removals are usually due to sub-dependencies updating minimum versions or removing sub-sub-dependencies, and so on. Further reading: https://pdm-project.org/latest/usage/lockfile/
… fixtures Add documentation for and , add example encrypted result files, and keep pyzipper-required crypto libraries in the PyInstaller spec excludes
3 participants
Feature/encrypted results
Description
Added the ability to zip/unzip encrypt/decrypt the
peat_resultsdirectory with cli commands. changed config encrypt functions naming for easier understanding. added alias to originalencrypt-configfor legacy purposes and fixed subparser loop so it doesn't error on the alias feature.Related Issue
Closes: #19
Checklist
Please check the following items as they're completed.
Completion of all checklist items signals to maintainers that a PR is fully ready for review.
CHANGELOG.rst