Skip to content

Add openssl pkg to alpine to provide libcrypto #2116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
heewa wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add openssl pkg to alpine to provide libcrypto #2116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bootstrap-salt.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5468,7 +5468,7 @@ install_alpine_linux_git_deps() {
# shellcheck disable=SC2119
__git_clone_and_checkout || return 1

apk -U add python3 python3-dev py3-pip py3-setuptools g++ linux-headers zeromq-dev openrc || return 1
apk -U add python3 python3-dev py3-pip py3-setuptools g++ linux-headers zeromq-dev openrc openssl-dev || return 1

@twangboy twangboy Jul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocker: The PR title and description state that this is adding the openssl package to provide libcrypto for a runtime dependency. However, the code adds openssl-dev instead of openssl.

If the goal is strictly to provide the libcrypto shared library for runtime execution, we should just install openssl (or libcrypto3/libcrypto1.1 explicitly depending on the Alpine version) to keep the bootstrap footprint minimal. Adding -dev headers introduces unnecessary build dependencies unless we are explicitly compiling a Python wheel against OpenSSL headers during this git dependency installation phase.

If we do need the development headers for a compilation step here, the PR title should be updated to reflect that, but otherwise, this should be switched to the runtime package.

Suggested Change:

apk -U add python3 python3-dev py3-pip py3-setuptools g++ linux-headers zeromq-dev openrc openssl || return 1

_PY_EXE=python3
return 0
}
Expand Down