Skip to content

WIP: late fields POC#933

Open
puuuuh wants to merge 10 commits into
salsa-rs:masterfrom
puuuuh:master
Open

WIP: late fields POC#933
puuuuh wants to merge 10 commits into
salsa-rs:masterfrom
puuuuh:master

Conversation

@puuuuh

@puuuuh puuuuh commented Jul 6, 2025

Copy link
Copy Markdown
Contributor

Basic impl of #581

@netlify

netlify Bot commented Jul 6, 2025

Copy link
Copy Markdown

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 0dd3f0d
🔍 Latest deploy log https://app.netlify.com/projects/salsa-rs/deploys/686aab6d6e0075000861cace

@puuuuh

puuuuh commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

I wonder if we can use empty update fn in $maybe_update instead of no_backdate special-casing

@codspeed-hq

codspeed-hq Bot commented Jul 6, 2025

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 3 untouched benchmarks
🗄️ 9 archived benchmarks run1


Comparing puuuuh:master (0dd3f0d) with master (d28d66b)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were run, but are now archived. If they were deleted in another branch, consider rebasing to remove them from the report. Instead if they were added back, click here to restore them.

@puuuuh

puuuuh commented Jul 6, 2025

Copy link
Copy Markdown
Contributor Author

Also probably its better to store durability in LateField, so we can change field durability after set is called

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant