Skip to content

SAK-51938 Lessons page accessible via direct link but not visible in the portals (left-hand) navigation menu#281

Open
st-manu wants to merge 2 commits intosakaiproject:masterfrom
st-manu:SAK-51938
Open

SAK-51938 Lessons page accessible via direct link but not visible in the portals (left-hand) navigation menu#281
st-manu wants to merge 2 commits intosakaiproject:masterfrom
st-manu:SAK-51938

Conversation

@st-manu
Copy link
Copy Markdown
Contributor

@st-manu st-manu commented Dec 18, 2025

Summary by CodeRabbit

  • Chores
    • Updated database migration scripts for MySQL and Oracle to add a new column to the lesson builder pages table, with default value configuration and data migration for existing records.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 18, 2025

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7c981897-9aff-4902-9933-ef457dcc2b94

📥 Commits

Reviewing files that changed from the base of the PR and between b357117 and 233c37b.

📒 Files selected for processing (2)
  • docs/conversion/sakai_25_1-25_2_mysql_conversion.sql
  • docs/conversion/sakai_25_1-25_2_oracle_conversion.sql
✅ Files skipped from review due to trivial changes (1)
  • docs/conversion/sakai_25_1-25_2_mysql_conversion.sql
🚧 Files skipped from review as they are similar to previous changes (1)
  • docs/conversion/sakai_25_1-25_2_oracle_conversion.sql

Walkthrough

Adds database migration scripts for MySQL and Oracle that introduce a new hiddenFromNavigation column to the lesson_builder_pages table as part of SAK-51938, initializing the column with a default value of 0 for all existing rows.

Changes

Cohort / File(s) Summary
Database Migration Scripts
docs/conversion/sakai_25_1-25_2_mysql_conversion.sql, docs/conversion/sakai_25_1-25_2_oracle_conversion.sql
Adds SAK-51938 migration steps introducing hiddenFromNavigation column to lesson_builder_pages. MySQL uses bit(1) type, Oracle uses NUMBER(1,0) type, both with DEFAULT 0. Updates existing rows to set the new column value.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title clearly describes the main feature being implemented: making Lessons pages inaccessible from navigation while remaining accessible via direct link, matching the SQL schema changes that add a hiddenFromNavigation column.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
⚔️ Resolve merge conflicts
  • Resolve merge conflict in branch SAK-51938

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ottenhoff
Copy link
Copy Markdown
Contributor

i think this jira in the title is wrong?

@st-manu st-manu changed the title SAK-51713 Tests & Quizzes Instructors should see all student submissions when a assessment is published to the entire site SAK-51938 Lessons page accessible via direct link but not visible in the portals (left-hand) navigation menu Apr 10, 2026
@st-manu
Copy link
Copy Markdown
Contributor Author

st-manu commented Apr 10, 2026

@ottenhoff correct, this was the one for Lessons

Comment thread docs/conversion/sakai_25_1-25_2_mysql_conversion.sql
@ottenhoff
Copy link
Copy Markdown
Contributor

ok great. now you can delete the lines from docs/conversion/sakai_26_mysql_conversion.sql .... the conversion should only be in one file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants