fix(lsp): only call notify_reply_callback once the request is actually resolved#171
Closed
fix(lsp): only call notify_reply_callback once the request is actually resolved#171
Conversation
Owner
Author
|
Oh, never mind the |
Contributor
|
Yep, since neovim/neovim#33624 it is synchronous aware. |
Owner
Author
|
So just to clarify, should |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #167
The
completefunction might do some async work, such as fetching crates.io versions or searches.If I understand correctly a lsp request has 3 states
pending,cancel, andcomplete.The documentation says to call the callback once the request is no longer
pending, which (because we don't handle cancellation) would make it complete right?So this just schedules the
notify_reply_callbackafter thecallbackhas been called by the request handler.Are my thoughts correct here, or is the no longer pending more of a: when work has started?
@PolyMeilex I would appreciate your input on this manner :)