Skip to content

fix: Prevent lsp request from beeing endlesly pending #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saecki merged 2 commits into from
Aug 1, 2025
Merged

fix: Prevent lsp request from beeing endlesly pending #167

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c037b04
Prevent endless lsp request
PolyMeilex Apr 25, 2025
e4a1ef3
Annotate notify_reply_callback as nullable
PolyMeilex Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion lua/crates/lsp.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ function M.server(opts)
---@param method string
---@param params any
---@param callback fun(method: string?, params: any)
---@param notify_reply_callback fun(request_id: integer)
Comment thread
saecki marked this conversation as resolved.
Outdated
---@return boolean
---@return integer
function srv.request(method, params, callback)
function srv.request(method, params, callback, notify_reply_callback)
pcall(on_request, method, params)
local handler = handlers[method]
if handler then
Expand All @@ -56,6 +57,9 @@ function M.server(opts)
callback(nil, nil)
end
request_id = request_id + 1
if notify_reply_callback then
notify_reply_callback(request_id)
end
return true, request_id
end

Expand Down
Loading