Skip to content

Fix #1369 - #1382

Open
S-Bhattacharya240611 wants to merge 2 commits into
rzellem:developfrom
S-Bhattacharya240611:fix-1369
Open

Fix #1369#1382
S-Bhattacharya240611 wants to merge 2 commits into
rzellem:developfrom
S-Bhattacharya240611:fix-1369

Conversation

@S-Bhattacharya240611

Copy link
Copy Markdown

Auto-fix

@S-Bhattacharya240611

Copy link
Copy Markdown
Author

Additional validation after opening PR:

  • Re-read README.md and docs/README.md. README recommends validating with the HAT-P-32 b sample dataset.
  • Cloned rzellem/EXOTIC_sampledata locally; confirmed 142 FITS files in sample-data/HatP32Dec202017.
  • Re-ran python -c "import exotic": passed.
  • Re-ran pytest tests/test_utils.py: 32 passed.
  • Ran focused Colab validation against the first sample FITS file (OBSERVAT=Whipple Observatory) through exotic.api.colab.find() and make_inits_file(). Verified generated inits values:
    • Filter Name: CV
    • Obs. Latitude: +31.675467
    • Obs. Longitude: -110.951376
    • Obs. Elevation: 1268
    • Pixel Binning: 2x2
    • Secondary Observer Codes: MOBS

Full README sample reduction was also attempted with python exotic/exotic.py -red sample-data/inits-local.json -ov. It started the Complete Reduction routine but failed outside this change while LDTK attempted FTP limb-darkening grid access: ftplib.error_reply: 229 Extended Passive Mode Entered. That failure is in external LDTK data retrieval, not the Colab MObs metadata path changed by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant