fix: retry AppImage downloads and trust Homebrew taps - #50
Merged
Conversation
Two CI-hardening fixes for transient integration failures on main: - Retry AppImage downloads (3 attempts, 5s delay) in the ubuntu, debian, and fedora playbooks so a single connection reset no longer fails the run. - Trust managed Homebrew taps via `brew trust` on macOS: Homebrew 6.x ignores formulae/casks from untrusted third-party taps. Guarded so older brew without the subcommand skips the task, with a matching guarded check in the macOS verify script. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QJj6XYRzcj3dCY9GSAzB1g
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two CI-hardening fixes for the transient integration failures seen on main today (runs 32577781988 and 32575152063):
Download AppImagetask in the ubuntu, debian, and fedora playbooks now retries up to 3 times with a 5s delay, so a singleConnection reset by peerfrom GitHub releases no longer fails the whole run.brew trust --json v1and runsbrew trust --tap <tap>for any managed tap not yet trusted. Both tasks are guarded so older brew without thebrew trustsubcommand skips them cleanly, and the second run stays idempotent (already-trusted taps produce zero changes). The macOS verify script gains a matching guarded assertion thathashicorp/tapis trusted.Test plan
uvx yamllintclean on all four playbooksuvx ansible-lintclean on all four playbooksshellcheck tests/macOS/verify.shclean🤖 Generated with Claude Code
https://claude.ai/code/session_01QJj6XYRzcj3dCY9GSAzB1g