Repository navigation
Links to GitHub ... compare page in our range-diff viewer - #2530
Merged
Merged
Conversation
RalfJung
reviewed
Oct 10, 2026
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| <link rel="icon" sizes="32x32" type="image/png" href="https://rust-lang.org/static/images/favicon-32x32.png"> | ||
| <title>range-diff of {oldbase}..{oldhead} {newbase}..{newhead}</title> | ||
| <title>range-diff of {oldbase}...{oldhead} {newbase}...{newhead}</title> |
Member
There was a problem hiding this comment.
.. is the normal git notation and I think we should keep using it in the title. GH is just being weird.
Member
There was a problem hiding this comment.
That said, what we do here is very different from an actual git range-diff, so this is kind of confusing either way. git range-diff diffs commits against each other, whereas we diff the end-to-end diffs against each other. Both have their place (e.g. git range-diff is useless to compare a PR before and after squashing), they are just different.
Member
Author
There was a problem hiding this comment.
Yeah, this is indeed a bit weird.
Reverted to displaying only .. (double dots) for now, we can change it later if it's too confusing.
Kobzol
approved these changes
Oct 10, 2026
Urgau
force-pushed
the
gh-range-diff-triple-dots
branch
from
October 10, 2026 11:28
0dfedcc to
6847bb1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes our links to GitHub compare page by using
...(triple dots) instread by..(double dots) in our range-diff viewer.Fixes #2529