Skip to content

Don't mention the author in CC - #2250

Merged
Kobzol merged 1 commit into
rust-lang:masterfrom
JonathanBrouwer:no-mention-author
Jan 13, 2026
Merged

Kobzol merged 1 commit into
rust-lang:masterfrom
JonathanBrouwer:no-mention-author

Conversation

@JonathanBrouwer

@JonathanBrouwer JonathanBrouwer commented Jan 12, 2026 •

Copy link
Copy Markdown
Member

There is an existing check but this only works if only one person is in the CC list
Got annoyed by getting pings for my own PRs, so decided to do something about it :P

Code is completely untested, not sure if there is a good way to test it?

@JonathanBrouwer

Copy link
Copy Markdown
Member Author

Oh wait this is just not correct, gimme a second

@JonathanBrouwer
JonathanBrouwer marked this pull request as draft January 12, 2026 19:26
@JonathanBrouwer
JonathanBrouwer force-pushed the no-mention-author branch 3 times, most recently from 659ccd0 to 6d40c9c Compare January 12, 2026 19:34
@JonathanBrouwer
JonathanBrouwer marked this pull request as ready for review January 12, 2026 19:35
@JonathanBrouwer

Copy link
Copy Markdown
Member Author

That should be better, still completely untested tho.
Is there a good way to write a test for this?

@Kobzol Kobzol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can currently easily test this, definitely not end-to-end :(

View changes since this review

Comment thread src/handlers/mentions.rs Resolved

@Kobzol Kobzol left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Kobzol
Kobzol added this pull request to the merge queue Jan 13, 2026
Merged via the queue into rust-lang:master with commit 82f9d73 Jan 13, 2026
3 checks passed
@Urgau Urgau mentioned this pull request Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants