Skip to content

Log error instead of printf #2247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Urgau merged 1 commit into from
Jan 9, 2026
Merged

Log error instead of printf #2247

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/handlers/relabel.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ use crate::{
use anyhow::Context as _;
use parser::command::relabel::{LabelDelta, RelabelCommand};

use tracing as log;

pub(super) async fn handle_command(
ctx: &Context,
config: &RelabelConfig,
Expand Down Expand Up @@ -86,7 +88,7 @@ async fn is_member(user: &github::User, client: &TeamClient) -> TeamMembership {
Ok(true) => TeamMembership::Member,
Ok(false) => TeamMembership::Outsider,
Err(err) => {
eprintln!("failed to check team membership: {err:?}");
log::error!("failed to check team membership: {err:?}");
TeamMembership::Unknown
}
}
Expand Down Expand Up @@ -120,7 +122,7 @@ fn check_filter(
}
Ok(MatchPatternResult::NoMatch) => {}
Err(err) => {
eprintln!("failed to match pattern {pattern}: {err}");
log::error!("failed to match pattern {pattern}: {err}");
return Err(format!("failed to match pattern {pattern}"));
}
}
Expand Down