Skip to content

Post a user message when a command processing fails - #2209

Merged
Kobzol merged 1 commit into
rust-lang:masterfrom
Urgau:commands-user-error
Oct 25, 2025
Merged

Kobzol merged 1 commit into
rust-lang:masterfrom
Urgau:commands-user-error

Conversation

@Urgau

@Urgau Urgau commented Oct 24, 2025

Copy link
Copy Markdown
Member

This PR adds a user message when a command handler unexpectedly fails with a link to the comment in question as well as a the header of error.

It's not perfect as it may leak unwanted information but it's better than silently failing.

It even works fairly well with UnknownLabels:

Error: shortcut handler unexpectedly failed in this comment: Unknown labels: S-waiting-on-review

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #triagebot on Zulip.

@Urgau
Urgau requested a review from Kobzol October 24, 2025 21:50
@Kobzol
Kobzol added this pull request to the merge queue Oct 25, 2025
Merged via the queue into rust-lang:master with commit 5424b88 Oct 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants