Repository navigation
Exclude drafts from auto-backport nomination - #2170
Merged
Kobzol merged 1 commit intoOct 31, 2025
Merged
Conversation
jieyouxu
approved these changes
Sep 2, 2025
Member
|
r? triagebot |
Kobzol
requested changes
Sep 2, 2025
apiraino
force-pushed
the
exclude-drafts-from-auto-backport-nominate
branch
from
September 2, 2025 10:56
31cc5f1 to
68de8c8
Compare
Kobzol
reviewed
Sep 2, 2025
Member
There was a problem hiding this comment.
I'm not sure what should happen when the PR is undrafted - should this handler run to check for backports? If yes, then we might want to add IssuesAction::ReadyForReview, because I don't think that Edited runs when the PR is converted away from a draft.
apiraino
force-pushed
the
exclude-drafts-from-auto-backport-nominate
branch
from
October 31, 2025 14:18
68de8c8 to
2df24a0
Compare
apiraino
force-pushed
the
exclude-drafts-from-auto-backport-nominate
branch
from
October 31, 2025 15:39
2df24a0 to
d4cd168
Compare
Contributor
Author
|
@Kobzol back to this old small patch (had forgot about yr comment). I inverted the check boolean logic and added your suggestions. Feel to have a look when you have a sec. thanks |
Kobzol
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a mechanism (see 2556583) that auto-nominates pull requests for a backport if they fix a P-high/P-critical regression.
@jieyouxu suggested in this Zulip comment to exclude pull requests drafts from this mechanism (which makes sense), so this patch implements this suggestion.
r? @jieyouxu
thanks for a review :)