Repository navigation
Integrate stdarch tests for aarch64 - #1667
Conversation
Yeah, I think that would work better. Aside from currently being a shorter list, it also avoids mistakenly thinking a new failing test got added that can be disabled just fine rather than an existing test now failing. |
This comment has been minimized.
This comment has been minimized.
|
Now uses Switching from opt-out to opt-in will require some upstream work in The opt-in lists would likely be longer than the existing skip lists fwiw. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
bdc1ca7 to
558ce35
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Rebased and dropped the lockfile generation. Refreshed the skip lists as well. The patch approach also needed to be tweaked, now filtering out SVE/SVE2 generated tests manually, due to rust-lang/stdarch#2160. |
|
Thanks a lot for implementing this! |
Had a go at wiring up
stdarch. Runs thecore_archandintrinsic-testtest suites.Looked into x86 as well. It had more hard errors to resolve up front, so opted to stick with aarch64 for now.
The skip mechanism for these may be a little cumbersome to maintain.
Maybe making the tests opt-in rather than opt-out would be the better approach?