Skip to content

Fix reflection ICE in tuple type info - #165150

Open
yara-blue wants to merge 1 commit into
rust-lang:mainfrom
yara-blue:reflection-fix-silly-tuple-ice
Open

yara-blue wants to merge 1 commit into
rust-lang:mainfrom
yara-blue:reflection-fix-silly-tuple-ice

Conversation

@yara-blue

Copy link
Copy Markdown
Contributor

We removed most fields from the TypeKind enum. I forgot to take out the code writing out the field of TypeKind::Tuple. When calling TypeId::info() with a tuple we get an ICE. This fixes that by taking out the code that should have been removed a while ago.

@rustbot

rustbot commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE machinery

cc @RalfJung, @oli-obk, @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 29, 2026
@rustbot

rustbot commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

r? @jackh726

rustbot has assigned @jackh726.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 21 candidates

@rust-log-analyzer

Copy link
Copy Markdown
Collaborator

The job test-x86_64-gnu-miri failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants