Skip to content

Remove the unused generic Graphviz writer - #165142

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TaKO8Ki:remove-unused-generic-graphviz
Oct 31, 2026
Merged

Remove the unused generic Graphviz writer#165142
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
TaKO8Ki:remove-unused-generic-graphviz

Conversation

@TaKO8Ki

@TaKO8Ki TaKO8Ki commented Oct 29, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

This module was introduced in #78267, but it has been unused since #115962 was merged.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 29, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 29, 2026
@rustbot

rustbot commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

r? @mejrs

rustbot has assigned @mejrs.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler, mir
  • compiler, mir expanded to 77 candidates
  • Random selection from 20 candidates

@lqd

lqd commented Oct 29, 2026

Copy link
Copy Markdown
Member

Nice find. r=me with green CI. r? me

@rustbot rustbot assigned lqd and unassigned mejrs Oct 29, 2026
@rust-log-analyzer

This comment was marked as outdated.

Sign in to view
@TaKO8Ki

TaKO8Ki commented Oct 29, 2026

Copy link
Copy Markdown
Member Author

@bors r=lqd

@rust-bors

rust-bors Bot commented Oct 29, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 15f4fa6 has been approved by lqd

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 29, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 30, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165142 - TaKO8Ki:remove-unused-generic-grap…
45c8e7e 
…hviz, r=lqd

Remove the unused generic Graphviz writer

This module was introduced in rust-lang#78267, but it has been unused since rust-lang#115962 was merged.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 30, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 30, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165142 - TaKO8Ki:remove-unused-generic-grap…
33bd0f3 
…hviz, r=lqd

Remove the unused generic Graphviz writer

This module was introduced in rust-lang#78267, but it has been unused since rust-lang#115962 was merged.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 30, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 30, 2026
@bors
Auto merge of #165178 - JonathanBrouwer:rollup-AjO9tyO, r=JonathanBro…
44b4d86 
…uwer

Rollup of 21 pull requests

Successful merges:

 - #164851 (Add behavior tests for `Arc` and `Rc`)
 - #164989 (rustdoc: Fix performance regression for private documented items)
 - #165079 (Remove GenericArgRef)
 - #161781 (Don't emit InlineAsm terminator if input operand is `!`.)
 - #162754 (optimize large elements for slice rotating)
 - #163252 (Remove windows-targets dependency from the root workspace)
 - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`)
 - #165104 (Use getrandom instead of /scheme/rand on Redox OS)
 - #165132 (Implement `advance_back_by` on `Fuse`)
 - #165142 (Remove the unused generic Graphviz writer)
 - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output)
 - #163802 (fix RegionEq direction in canonical query responses)
 - #163986 (omit unconditionally invoking crate level limits query)
 - #164920 (Point at prior token on `let` when expression is expected)
 - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop)
 - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols)
 - #165114 (use native interpreter impl for funnel shifts intrinsics)
 - #165119 (remove unnecessary fast path from borrowck)
 - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX)
 - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`)
 - #165129 (Fix ICE in prelude edition lint)

Failed merges:

 - #164981 (Reflection add TypeId::name)
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 30, 2026
@JonathanBrouwer
Rollup merge of rust-lang#165142 - TaKO8Ki:remove-unused-generic-grap…
73d5a56 
…hviz, r=lqd

Remove the unused generic Graphviz writer

This module was introduced in rust-lang#78267, but it has been unused since rust-lang#115962 was merged.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 30, 2026
Closed
rust-bors Bot pushed a commit that referenced this pull request Oct 30, 2026
@bors
Auto merge of #165208 - JonathanBrouwer:rollup-vnejtzq, r=JonathanBro…
129738e 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #164851 (Add behavior tests for `Arc` and `Rc`)
 - #164989 (rustdoc: Fix performance regression for private documented items)
 - #165079 (Remove GenericArgRef)
 - #161781 (Don't emit InlineAsm terminator if input operand is `!`.)
 - #162754 (optimize large elements for slice rotating)
 - #163252 (Remove windows-targets dependency from the root workspace)
 - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`)
 - #165104 (Use getrandom instead of /scheme/rand on Redox OS)
 - #165132 (Implement `advance_back_by` on `Fuse`)
 - #165142 (Remove the unused generic Graphviz writer)
 - #165148 (ci: increase free disk space on macos-26 jobs)
 - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output)
 - #163802 (fix RegionEq direction in canonical query responses)
 - #163986 (omit unconditionally invoking crate level limits query)
 - #164920 (Point at prior token on `let` when expression is expected)
 - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop)
 - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols)
 - #165114 (use native interpreter impl for funnel shifts intrinsics)
 - #165119 (remove unnecessary fast path from borrowck)
 - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX)
 - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`)
 - #165129 (Fix ICE in prelude edition lint)

Failed merges:

 - #164981 (Reflection add TypeId::name)

> [!WARNING]
> This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.
rust-bors Bot pushed a commit that referenced this pull request Oct 31, 2026
@bors
Auto merge of #165208 - JonathanBrouwer:rollup-vnejtzq, r=JonathanBro…
5735bf2 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #164851 (Add behavior tests for `Arc` and `Rc`)
 - #164989 (rustdoc: Fix performance regression for private documented items)
 - #165079 (Remove GenericArgRef)
 - #161781 (Don't emit InlineAsm terminator if input operand is `!`.)
 - #162754 (optimize large elements for slice rotating)
 - #163252 (Remove windows-targets dependency from the root workspace)
 - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`)
 - #165104 (Use getrandom instead of /scheme/rand on Redox OS)
 - #165132 (Implement `advance_back_by` on `Fuse`)
 - #165142 (Remove the unused generic Graphviz writer)
 - #165148 (ci: increase free disk space on macos-26 jobs)
 - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output)
 - #163802 (fix RegionEq direction in canonical query responses)
 - #163986 (omit unconditionally invoking crate level limits query)
 - #164920 (Point at prior token on `let` when expression is expected)
 - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop)
 - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols)
 - #165114 (use native interpreter impl for funnel shifts intrinsics)
 - #165119 (remove unnecessary fast path from borrowck)
 - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX)
 - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`)
 - #165129 (Fix ICE in prelude edition lint)

Failed merges:

 - #164981 (Reflection add TypeId::name)

> [!WARNING]
> This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.
rust-bors Bot pushed a commit that referenced this pull request Oct 31, 2026
@bors
Auto merge of #165208 - JonathanBrouwer:rollup-vnejtzq, r=JonathanBro…
5759ff7 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #164851 (Add behavior tests for `Arc` and `Rc`)
 - #164989 (rustdoc: Fix performance regression for private documented items)
 - #165079 (Remove GenericArgRef)
 - #161781 (Don't emit InlineAsm terminator if input operand is `!`.)
 - #162754 (optimize large elements for slice rotating)
 - #163252 (Remove windows-targets dependency from the root workspace)
 - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`)
 - #165104 (Use getrandom instead of /scheme/rand on Redox OS)
 - #165132 (Implement `advance_back_by` on `Fuse`)
 - #165142 (Remove the unused generic Graphviz writer)
 - #165148 (ci: increase free disk space on macos-26 jobs)
 - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output)
 - #163802 (fix RegionEq direction in canonical query responses)
 - #163986 (omit unconditionally invoking crate level limits query)
 - #164920 (Point at prior token on `let` when expression is expected)
 - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop)
 - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols)
 - #165114 (use native interpreter impl for funnel shifts intrinsics)
 - #165119 (remove unnecessary fast path from borrowck)
 - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX)
 - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`)
 - #165129 (Fix ICE in prelude edition lint)

Failed merges:

 - #164981 (Reflection add TypeId::name)

> [!WARNING]
> This rollup conflicts with pending auto build #165205 and may need to be recreated if the pending build succeeds.
@JonathanBrouwer JonathanBrouwer mentioned this pull request Oct 31, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Oct 31, 2026
@bors
Auto merge of #165234 - JonathanBrouwer:rollup-xeZSZRm, r=JonathanBro…
5a2a795 
…uwer

Rollup of 22 pull requests

Successful merges:

 - #164851 (Add behavior tests for `Arc` and `Rc`)
 - #164989 (rustdoc: Fix performance regression for private documented items)
 - #165079 (Remove GenericArgRef)
 - #161781 (Don't emit InlineAsm terminator if input operand is `!`.)
 - #162754 (optimize large elements for slice rotating)
 - #163252 (Remove windows-targets dependency from the root workspace)
 - #163839 (Fix the floating point clobbers of RISC-V `clobber_abi`)
 - #165104 (Use getrandom instead of /scheme/rand on Redox OS)
 - #165132 (Implement `advance_back_by` on `Fuse`)
 - #165142 (Remove the unused generic Graphviz writer)
 - #165233 (Remove test-aarch64-apple-* jobs temporarily)
 - #163371 (Don't suggest replacing foreign format specifiers in `concat!` output)
 - #163802 (fix RegionEq direction in canonical query responses)
 - #163986 (omit unconditionally invoking crate level limits query)
 - #164920 (Point at prior token on `let` when expression is expected)
 - #164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop)
 - #165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols)
 - #165114 (use native interpreter impl for funnel shifts intrinsics)
 - #165119 (remove unnecessary fast path from borrowck)
 - #165122 (fix MaybeDangling validity logic for ZST at usize::MAX)
 - #165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`)
 - #165129 (Fix ICE in prelude edition lint)

> [!WARNING]
> This rollup conflicts with pending auto build #165217 and may need to be recreated if the pending build succeeds.
@rust-bors
rust-bors Bot merged commit 23957ae into rust-lang:main Oct 31, 2026
18 of 27 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 31, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 31, 2026
@bors
Unrolled build for #165142 in rollup 165234
c2571d6 
Rollup merge of #165142 - TaKO8Ki:remove-unused-generic-graphviz, r=lqd

Remove the unused generic Graphviz writer

This module was introduced in #78267, but it has been unused since #115962 was merged.
eduardorittner pushed a commit to eduardorittner/miri that referenced this pull request Nov 2, 2026
@bors
Auto merge of #165234 - JonathanBrouwer:rollup-xeZSZRm, r=JonathanBro…
5234b75 
…uwer

Rollup of 22 pull requests

Successful merges:

 - rust-lang/rust#164851 (Add behavior tests for `Arc` and `Rc`)
 - rust-lang/rust#164989 (rustdoc: Fix performance regression for private documented items)
 - rust-lang/rust#165079 (Remove GenericArgRef)
 - rust-lang/rust#161781 (Don't emit InlineAsm terminator if input operand is `!`.)
 - rust-lang/rust#162754 (optimize large elements for slice rotating)
 - rust-lang/rust#163252 (Remove windows-targets dependency from the root workspace)
 - rust-lang/rust#163839 (Fix the floating point clobbers of RISC-V `clobber_abi`)
 - rust-lang/rust#165104 (Use getrandom instead of /scheme/rand on Redox OS)
 - rust-lang/rust#165132 (Implement `advance_back_by` on `Fuse`)
 - rust-lang/rust#165142 (Remove the unused generic Graphviz writer)
 - rust-lang/rust#165233 (Remove test-aarch64-apple-* jobs temporarily)
 - rust-lang/rust#163371 (Don't suggest replacing foreign format specifiers in `concat!` output)
 - rust-lang/rust#163802 (fix RegionEq direction in canonical query responses)
 - rust-lang/rust#163986 (omit unconditionally invoking crate level limits query)
 - rust-lang/rust#164920 (Point at prior token on `let` when expression is expected)
 - rust-lang/rust#164987 (use adt_async_drop_tys for nested ADTs in needs_async_drop)
 - rust-lang/rust#165061 (Use a fixed-length encoding for hash disambiguators in v0 symbols)
 - rust-lang/rust#165114 (use native interpreter impl for funnel shifts intrinsics)
 - rust-lang/rust#165119 (remove unnecessary fast path from borrowck)
 - rust-lang/rust#165122 (fix MaybeDangling validity logic for ZST at usize::MAX)
 - rust-lang/rust#165128 (Move `doc(keyword)` and `doc(attribute)` attributes checks from `rustc_passes` to `rustc_attr_parsing`)
 - rust-lang/rust#165129 (Fix ICE in prelude edition lint)

> [!WARNING]
> This rollup conflicts with pending auto build #165217 and may need to be recreated if the pending build succeeds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lqd lqd

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.101.0

Development

Successfully merging this pull request may close these issues.

5 participants

@TaKO8Ki @rustbot @lqd @rust-log-analyzer @mejrs