Repository navigation
Conversation
Collaborator
|
r? @nnethercote rustbot has assigned @nnethercote. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
Author
|
lol that must be from the rollup that got merged 3 minutes ago. Whoops. I'll fix that when I get home |
Contributor
|
I don't know anything about this stuff, let's pick a better reviewer: r? @davidtwco |
Walnut356
force-pushed
the
unsized_vis
branch
from
October 27, 2026 06:10
1d7db9a to
002a487
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This visualizer handles wide pointers to
?Sizedtypes, e.g.These were undecidable not too long ago, but we now have enough information to reliably visualize these properly.
lldb 23 added the ability for an
SBValueobject to acquire its parent, which is very helpful for this so we can retrieve the length. Prior to lldb 22, the best option we have is to store a reference to the parent wide pointer within python itself and retrieve them in the child's visualizer (this happens viaWidePtrSyntheticProvider.WIDE_PTR_BY_UNSIZED_CHILD_ID. I know it's maybe a bit hack-y, but this is semi-canonical and CodeLLDB did it pretty extensively in their visualizers). Using that method, we are thankfully able to get identical output between lldb 22 and 23.As a note, this visualizer does not work for MSVC at the moment because LLDB pretends zero-sized fields in PDB debug info don't exist =)