Repository navigation
Add example for misaligned elements in subslice_range - #164937
Open
asquared31415 wants to merge 1 commit into
Open
asquared31415 wants to merge 1 commit into
asquared31415 wants to merge 1 commit into
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @clarfonthey rustbot has assigned @clarfonthey. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
Member
|
gcc seems to have failed for unrelated reasons, I restarted the jobs. |
teor2345
approved these changes
Oct 25, 2026
clarfonthey
requested changes
Oct 29, 2026
rustbot
added
S-waiting-on-author
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
rust-cloud-vms
Bot
force-pushed
the
slice_subslice_range_docs
branch
from
October 29, 2026 17:50
085334c to
c075e5e
Compare
rust-cloud-vms
Bot
force-pushed
the
slice_subslice_range_docs
branch
from
October 29, 2026 17:51
c075e5e to
747933f
Compare
Contributor
|
Thank you! @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It confused me how it would be possible for
subsliceto be not aligned toself, because I was only thinking about the alignment of the typeT, not whether the resulting indexes would be aligned (which actually depends on the size). Suggested in Zulip.The related function
element_offsethas a similar example.