Skip to content

Remove redundant vec and duplicate indexing in find_noop_landing_pads #164934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rust-bors merged 1 commit into from
Oct 26, 2026
Merged

Remove redundant vec and duplicate indexing in find_noop_landing_pads #164934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions compiler/rustc_mir_transform/src/remove_noop_landing_pads.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,15 +172,9 @@ fn find_noop_landing_pads<'tcx>(

// This is a post-order traversal, so that if A post-dominates B
// then A will be visited before B.
let postorder: Vec<_> = traversal::postorder(body).map(|(bb, _)| bb).collect();
for bb in postorder {
let is_nop_landing_pad = RemoveNoopLandingPads.is_nop_landing_pad(
tcx,
&body.basic_blocks[bb],
body,
&nop_landing_pads,
extra,
);
for (bb, bb_data) in traversal::postorder(body) {
let is_nop_landing_pad =
RemoveNoopLandingPads.is_nop_landing_pad(tcx, bb_data, body, &nop_landing_pads, extra);
if is_nop_landing_pad {
nop_landing_pads.insert(bb);
}
Expand Down
Loading