Repository navigation
Add diagnostic items for env::vars / env::vars_os - #164893
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @JohnTitor rustbot has assigned @JohnTitor. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
notriddle
force-pushed
the
env-diagnostics
branch
from
October 25, 2026 16:38
a9d8841 to
c19a268
Compare
Member
|
r? ChrisDenton |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 26, 2026
…Denton Add diagnostic items for env::vars / env::vars_os A WIP Clippy lint that uses this can be found at <https://github.com/rust-lang/rust-clippy/compare/master...notriddle:rust-clippy:manual-env-var?expand=1>
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 26, 2026
…Denton Add diagnostic items for env::vars / env::vars_os A WIP Clippy lint that uses this can be found at <https://github.com/rust-lang/rust-clippy/compare/master...notriddle:rust-clippy:manual-env-var?expand=1>
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
…uwer Rollup of 6 pull requests Successful merges: - #164617 (tools: remote-test-server: Fix UEFI crash return code) - #164549 (feat!: change return type of `TryFromIntError::kind`) - #164893 (Add diagnostic items for env::vars / env::vars_os) - #164897 (Add regression test for CoerceShared impl with unnormalizable target) - #164908 (Add regression test for self referential inherent associated type ICE) - #164925 (Cleanup `rustdoc-html` tests)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
Rollup of 6 pull requests Successful merges: - #164617 (tools: remote-test-server: Fix UEFI crash return code) - #164549 (feat!: change return type of `TryFromIntError::kind`) - #164893 (Add diagnostic items for env::vars / env::vars_os) - #164897 (Add regression test for CoerceShared impl with unnormalizable target) - #164908 (Add regression test for self referential inherent associated type ICE) - #164926 (Remove `type_array` from `rustc_codegen_ssa`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 26, 2026
Rollup merge of #164893 - notriddle:env-diagnostics, r=ChrisDenton Add diagnostic items for env::vars / env::vars_os A WIP Clippy lint that uses this can be found at <https://github.com/rust-lang/rust-clippy/compare/master...notriddle:rust-clippy:manual-env-var?expand=1>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A WIP Clippy lint that uses this can be found at https://github.com/rust-lang/rust-clippy/compare/master...notriddle:rust-clippy:manual-env-var?expand=1