Rollup of 8 pull requests by JonathanBrouwer · Pull Request #164875 · rust-lang/rust

JonathanBrouwer · 2026-10-24T21:20:50Z

Successful merges:

Add a future incompat warning for #[no_link] #164028 (Add a future incompat warning for #[no_link])
miri subtree update #164834 (miri subtree update)
Use the span of the doctest code block fence for figuring out the line number #164849 (Use the span of the doctest code block fence for figuring out the line number)
rustc_codegen_gcc subtree update #164869 (rustc_codegen_gcc subtree update)
library: optimize truncate method #157123 (library: optimize truncate method)
Optimize str.escape_default().to_string() #159916 (Optimize str.escape_default().to_string())
Do not checkout Cargo for bootstrap tests #164857 (Do not checkout Cargo for bootstrap tests)
cg_llvm: clarify Send / Sync story for modules #164872 (cg_llvm: clarify Send / Sync story for modules)

This is a pre-1.0 attribute that accidentally got stabilized. It was only meant for compiler plugins which we no longer support, not for regular crates. It is rather fragile and can easily lead to linker errors depending on where rustc decides to codegen functions and statics, which varies between rustc versions. It might also be unsound if a crate for example expects a global constructor it defined to run. Using it doesn't have an effect on the size of the produced binaries except when it defines a `#[used]` static given that we remove all unused functions and statics at link time already.

GenMC now supports weak CASes and the failure ordering of CASes. Hence, the CAS API is adjusted accordingly (no change in behavior for now).

Modeling spurious failures is opt-in (see `-Zmiri-genmc-weak-cas-spurious-failures`), since Miri-GenMC cannot bound all retry loops involving weak CASes (e.g., the ones in the standard library).

…al-context-ref-readonly Use `eval_context_ref` where mutable access is not needed

Update subtree sync docs

support __cxa_thread_atexit_impl and correctly handle thread cleanup on exit

GenMC: Support for weak CASes and CAS failure ordering

This updates the rust-version file to 8144389.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: rust-lang/rust@8144389 Filtered ref: rust-lang/miri@0ba9730 Upstream diff: rust-lang/rust@b6eeb93...8144389 This merge was created using https://github.com/rust-lang/josh-sync.

…round

Rustup

…cos-check-shim-sig macOS shims: migrate to check_shim_sig

…check_shim_sig`

…round Remove /tmp workaround now that rustdoc fixed the disk usage issue

JonathanBrouwer · 2026-10-24T21:21:05Z

@bors r+ p=5 force

Trying commonly failed jobs
@bors try jobs=dist-various-1,test-various,test-x86_64-gnu-aux,test-x86_64-msvc-1,test-aarch64-apple-1,test-aarch64-apple-2,test-x86_64-mingw-1,test-i686-msvc,test-armhf-gnu,test-x86_64-gnu-llvm-22-3

rust-bors · 2026-10-24T21:21:09Z

📌 Commit 6b7af33 has been approved by JonathanBrouwer

It is now in the queue for this repository.

Rollup of 8 pull requests try-job: dist-various-1 try-job: test-various try-job: test-x86_64-gnu-aux try-job: test-x86_64-msvc-1 try-job: test-aarch64-apple-1 try-job: test-aarch64-apple-2 try-job: test-x86_64-mingw-1 try-job: test-i686-msvc try-job: test-armhf-gnu try-job: test-x86_64-gnu-llvm-22-3

rust-log-analyzer · 2026-10-24T21:59:25Z

The job test-x86_64-gnu-llvm-22-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


test result: FAILED. 76 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out; finished in 584.35ms

all doctests ran in 1.12s; merged doctests compilation took 0.50s
error: doctest failed, to rerun pass `-p rustc_lint_defs --doc`
Bootstrap failed while executing `--stage 1 test --skip src/tools/tidy --skip src/tools/linkchecker`
Currently active steps:
test::CrateLibrustc { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: ["rustc-main", "rustc_abi", "rustc_arena", "rustc_ast", "rustc_ast_ir", "rustc_ast_lowering", "rustc_ast_passes", "rustc_ast_pretty", "rustc_attr_ir", "rustc_attr_parsing", "rustc_baked_icu_data", "rustc_borrowck", "rustc_builtin_macros", "rustc_codegen_llvm", "rustc_codegen_ssa", "rustc_const_eval", "rustc_crate_store", "rustc_data_structures", "rustc_driver", "rustc_driver_impl", "rustc_error_codes", "rustc_error_messages", "rustc_errors", "rustc_expand", "rustc_expand_queries", "rustc_feature", "rustc_fs_util", "rustc_graphviz", "rustc_hashes", "rustc_hir", "rustc_hir_analysis", "rustc_hir_id", "rustc_hir_pretty", "rustc_hir_typeck", "rustc_incremental", "rustc_index", "rustc_index_macros", "rustc_infer", "rustc_interface", "rustc_lexer", "rustc_lint", "rustc_lint_defs", "rustc_llvm", "rustc_log", "rustc_macros", "rustc_metadata", "rustc_middle", "rustc_mir_build", "rustc_mir_dataflow", "rustc_mir_transform", "rustc_monomorphize", "rustc_next_trait_solver", "rustc_parse", "rustc_parse_format", "rustc_passes", "rustc_pattern_analysis", "rustc_privacy", "rustc_proc_macro", "rustc_public", "rustc_public_bridge", "rustc_query_impl", "rustc_resolve", "rustc_sanitizers", "rustc_serialize", "rustc_session", "rustc_span", "rustc_structures", "rustc_symbol_mangling", "rustc_target", "rustc_thread_pool", "rustc_trait_selection", "rustc_traits", "rustc_transmute", "rustc_ty_utils", "rustc_ty_walk", "rustc_type_ir", "rustc_type_ir_macros", "rustc_windows_rc"] } at src/bootstrap/src/core/build_steps/test.rs:3445
test::Crate { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, mode: Rustc, crates: ["rustc-main", "rustc_abi", "rustc_arena", "rustc_ast", "rustc_ast_ir", "rustc_ast_lowering", "rustc_ast_passes", "rustc_ast_pretty", "rustc_attr_ir", "rustc_attr_parsing", "rustc_baked_icu_data", "rustc_borrowck", "rustc_builtin_macros", "rustc_codegen_llvm", "rustc_codegen_ssa", "rustc_const_eval", "rustc_crate_store", "rustc_data_structures", "rustc_driver", "rustc_driver_impl", "rustc_error_codes", "rustc_error_messages", "rustc_errors", "rustc_expand", "rustc_expand_queries", "rustc_feature", "rustc_fs_util", "rustc_graphviz", "rustc_hashes", "rustc_hir", "rustc_hir_analysis", "rustc_hir_id", "rustc_hir_pretty", "rustc_hir_typeck", "rustc_incremental", "rustc_index", "rustc_index_macros", "rustc_infer", "rustc_interface", "rustc_lexer", "rustc_lint", "rustc_lint_defs", "rustc_llvm", "rustc_log", "rustc_macros", "rustc_metadata", "rustc_middle", "rustc_mir_build", "rustc_mir_dataflow", "rustc_mir_transform", "rustc_monomorphize", "rustc_next_trait_solver", "rustc_parse", "rustc_parse_format", "rustc_passes", "rustc_pattern_analysis", "rustc_privacy", "rustc_proc_macro", "rustc_public", "rustc_public_bridge", "rustc_query_impl", "rustc_resolve", "rustc_sanitizers", "rustc_serialize", "rustc_session", "rustc_span", "rustc_structures", "rustc_symbol_mangling", "rustc_target", "rustc_thread_pool", "rustc_trait_selection", "rustc_traits", "rustc_transmute", "rustc_ty_utils", "rustc_ty_walk", "rustc_type_ir", "rustc_type_ir_macros", "rustc_windows_rc"] } at src/bootstrap/src/core/build_steps/test.rs:3452
Build completed unsuccessfully in 0:34:13

…uwer Rollup of 8 pull requests Successful merges: - #164028 (Add a future incompat warning for #[no_link]) - #164834 (miri subtree update) - #164849 (Use the span of the doctest code block fence for figuring out the line number) - #164869 (rustc_codegen_gcc subtree update) - #157123 (library: optimize truncate method) - #159916 (Optimize `str.escape_default().to_string()`) - #164857 (Do not checkout Cargo for bootstrap tests) - #164872 (cg_llvm: clarify Send / Sync story for modules)

rust-log-analyzer · 2026-10-24T22:37:19Z

The job test-x86_64-gnu-llvm-22-3 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)


test result: FAILED. 76 passed; 1 failed; 6 ignored; 0 measured; 0 filtered out; finished in 565.38ms

all doctests ran in 1.09s; merged doctests compilation took 0.49s
error: doctest failed, to rerun pass `-p rustc_lint_defs --doc`
Bootstrap failed while executing `--stage 1 test --skip src/tools/tidy --skip src/tools/linkchecker`
Currently active steps:
test::CrateLibrustc { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, crates: ["rustc-main", "rustc_abi", "rustc_arena", "rustc_ast", "rustc_ast_ir", "rustc_ast_lowering", "rustc_ast_passes", "rustc_ast_pretty", "rustc_attr_ir", "rustc_attr_parsing", "rustc_baked_icu_data", "rustc_borrowck", "rustc_builtin_macros", "rustc_codegen_llvm", "rustc_codegen_ssa", "rustc_const_eval", "rustc_crate_store", "rustc_data_structures", "rustc_driver", "rustc_driver_impl", "rustc_error_codes", "rustc_error_messages", "rustc_errors", "rustc_expand", "rustc_expand_queries", "rustc_feature", "rustc_fs_util", "rustc_graphviz", "rustc_hashes", "rustc_hir", "rustc_hir_analysis", "rustc_hir_id", "rustc_hir_pretty", "rustc_hir_typeck", "rustc_incremental", "rustc_index", "rustc_index_macros", "rustc_infer", "rustc_interface", "rustc_lexer", "rustc_lint", "rustc_lint_defs", "rustc_llvm", "rustc_log", "rustc_macros", "rustc_metadata", "rustc_middle", "rustc_mir_build", "rustc_mir_dataflow", "rustc_mir_transform", "rustc_monomorphize", "rustc_next_trait_solver", "rustc_parse", "rustc_parse_format", "rustc_passes", "rustc_pattern_analysis", "rustc_privacy", "rustc_proc_macro", "rustc_public", "rustc_public_bridge", "rustc_query_impl", "rustc_resolve", "rustc_sanitizers", "rustc_serialize", "rustc_session", "rustc_span", "rustc_structures", "rustc_symbol_mangling", "rustc_target", "rustc_thread_pool", "rustc_trait_selection", "rustc_traits", "rustc_transmute", "rustc_ty_utils", "rustc_ty_walk", "rustc_type_ir", "rustc_type_ir_macros", "rustc_windows_rc"] } at src/bootstrap/src/core/build_steps/test.rs:3445
test::Crate { build_compiler: Compiler { stage: 0, host: x86_64-unknown-linux-gnu, forced_compiler: false }, target: x86_64-unknown-linux-gnu, mode: Rustc, crates: ["rustc-main", "rustc_abi", "rustc_arena", "rustc_ast", "rustc_ast_ir", "rustc_ast_lowering", "rustc_ast_passes", "rustc_ast_pretty", "rustc_attr_ir", "rustc_attr_parsing", "rustc_baked_icu_data", "rustc_borrowck", "rustc_builtin_macros", "rustc_codegen_llvm", "rustc_codegen_ssa", "rustc_const_eval", "rustc_crate_store", "rustc_data_structures", "rustc_driver", "rustc_driver_impl", "rustc_error_codes", "rustc_error_messages", "rustc_errors", "rustc_expand", "rustc_expand_queries", "rustc_feature", "rustc_fs_util", "rustc_graphviz", "rustc_hashes", "rustc_hir", "rustc_hir_analysis", "rustc_hir_id", "rustc_hir_pretty", "rustc_hir_typeck", "rustc_incremental", "rustc_index", "rustc_index_macros", "rustc_infer", "rustc_interface", "rustc_lexer", "rustc_lint", "rustc_lint_defs", "rustc_llvm", "rustc_log", "rustc_macros", "rustc_metadata", "rustc_middle", "rustc_mir_build", "rustc_mir_dataflow", "rustc_mir_transform", "rustc_monomorphize", "rustc_next_trait_solver", "rustc_parse", "rustc_parse_format", "rustc_passes", "rustc_pattern_analysis", "rustc_privacy", "rustc_proc_macro", "rustc_public", "rustc_public_bridge", "rustc_query_impl", "rustc_resolve", "rustc_sanitizers", "rustc_serialize", "rustc_session", "rustc_span", "rustc_structures", "rustc_symbol_mangling", "rustc_target", "rustc_thread_pool", "rustc_trait_selection", "rustc_traits", "rustc_transmute", "rustc_ty_utils", "rustc_ty_walk", "rustc_type_ir", "rustc_type_ir_macros", "rustc_windows_rc"] } at src/bootstrap/src/core/build_steps/test.rs:3452
Build completed unsuccessfully in 0:27:30

rust-bors · 2026-10-24T22:38:05Z

💔 Test for c9b93d2 failed: CI. Failed job:

auto - test-x86_64-gnu-llvm-22-3 (web logs, enhanced plaintext logs)

rust-bors · 2026-10-25T00:15:59Z

💔 Test for f28250f failed: CI. Failed jobs:

try - test-armhf-gnu (web logs, enhanced plaintext logs)
try - test-various (web logs, enhanced plaintext logs)
try - test-x86_64-gnu-llvm-22-3 (web logs, enhanced plaintext logs)

rust-bors · 2026-10-25T02:03:22Z

PR #164028, which is a member of this rollup, was unapproved.

rust-bors · 2026-10-25T02:05:07Z

PR #164849, which is a member of this rollup, was unapproved.

xtqqczze and others added 30 commits May 29, 2026 21:21

library: optimize truncate method

840ff78

genmc/build,cpp: Update GenMC version to 0.19.0

bbcf01e

GenMC now supports weak CASes and the failure ordering of CASes. Hence, the CAS API is adjusted accordingly (no change in behavior for now).

diagnostics,genmc*: Support the failure ordering of CASes

cd09392

diagnostics,genmc*: Support weak CASes

c26810b

Modeling spurious failures is opt-in (see `-Zmiri-genmc-weak-cas-spurious-failures`), since Miri-GenMC cannot bound all retry loops involving weak CASes (e.g., the ones in the standard library).

Update subtree sync docs

0fc7ab9

Use eval_context_ref and &self where mutable access is not needed

6034ed9

do not call pthread dtors on main thread return

a80cbc8

test suite: also check output of native runs

6807931

add support for __cxa_thread_atexit_impl

1bc78f2

Document updating the gcc submodule

4f3cf97

Merge pull request rust-lang#5441 from programskillforverification/ev…

7a7967b

…al-context-ref-readonly Use `eval_context_ref` where mutable access is not needed

Merge pull request rust-lang#1007 from Kobzol/sync-docs

5893562

Update subtree sync docs

run the thread exit hooks also when exit() is called

3d8756a

allow leaks of pthread keys in the thread that calls exit

9f0b0f6

make windows tests cover the exit case as well

b4b59b0

proper test for yield-before-exit

e4d6be4

work around a genmc problem

faa74c1

Merge pull request rust-lang#5442 from RalfJung/main-thread-dtors

dcee488

support __cxa_thread_atexit_impl and correctly handle thread cleanup on exit

Merge pull request rust-lang#5437 from michaliskok/genmc-cas

dbe4ef7

GenMC: Support for weak CASes and CAS failure ordering

macOS shims: migrate to check_shim_sig

7a6d062

Prepare for merging from rust-lang/rust

6776628

This updates the rust-version file to 8144389.

fix windows tls native tests

f61ab11

also make __dso_handle available as weak symbol and remove std work-a…

38d78d6

…round

Merge pull request rust-lang#5446 from RalfJung/rustup

f282af4

Rustup

Merge pull request rust-lang#5445 from programskillforverification/ma…

b0d3a65

…cos-check-shim-sig macOS shims: migrate to check_shim_sig

migrate linux shim checks from using check_shim_sig_deprecated to `…

e8f4356

…check_shim_sig`

Remove /tmp workaround now that rustdoc fixed the disk usage issue

750d8d3

Merge pull request rust-lang#1008 from rust-lang/fix/remove-tmp-worka…

712fb6a

…round Remove /tmp workaround now that rustdoc fixed the disk usage issue

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2026

This comment has been minimized.

Sign in to view

rust-bors Bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 24, 2026

rust-bors Bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 25, 2026

jhpratt mentioned this pull request Oct 25, 2026

Add a future incompat warning for #[no_link] #164028

Open

jhpratt mentioned this pull request Oct 25, 2026

Use the span of the doctest code block fence for figuring out the line number #164849

Merged

jhpratt closed this Oct 25, 2026

rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 25, 2026

Navigation Menu

Repository navigation

Rollup of 8 pull requests - #164875

Rollup of 8 pull requests#164875
JonathanBrouwer wants to merge 124 commits into
rust-lang:mainfrom
JonathanBrouwer:rollup-8KWDSya

JonathanBrouwer commented Oct 24, 2026

Uh oh!

JonathanBrouwer commented Oct 24, 2026

Uh oh!

rust-bors Bot commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 24, 2026

Uh oh!

rust-bors Bot commented Oct 24, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Conversation

JonathanBrouwer commented Oct 24, 2026

Uh oh!

JonathanBrouwer commented Oct 24, 2026

Uh oh!

rust-bors Bot commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 24, 2026

Uh oh!

This comment has been minimized.

rust-log-analyzer commented Oct 24, 2026

Uh oh!

rust-bors Bot commented Oct 24, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

rust-bors Bot commented Oct 25, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants