Repository navigation
Suggest annotating closure parameters as references on E0597 - #164874
Closed
Muhtasim-Rasheed wants to merge 1 commit into
Closed
Muhtasim-Rasheed wants to merge 1 commit into
Muhtasim-Rasheed wants to merge 1 commit into
Conversation
When a closure parameter has no type annotation, its type is inferred from the first call which fixes a single lifetime for the parameter instead of making the closure higher-ranked. If a later call passes a shorter borrow, it fails with E0597 and nothing points at the cause. If the region in the error comes from the type of a closure bound with "let", and the borrow goes into a call argument whose parameter has no annotation, suggest ": &_" for that parameter.
rustbot
added
S-waiting-on-review
Collaborator
|
r? @folkertdev rustbot has assigned @folkertdev. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Contributor
Author
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #164504
When a closure parameter has no type annotation, its type is inferred from the first call which fixes a single lifetime for the parameter instead of making the closure higher-ranked. If a later call passes a shorter borrow, it fails with E0597 and nothing points at the cause. If the region in the error comes from the type of a closure bound with "let", and the borrow goes into a call argument whose parameter has no annotation, suggest ": &_" for that parameter