Add behavior tests for `Arc` and `Rc` by EFanZh · Pull Request #164851 · rust-lang/rust

EFanZh · 2026-10-24T12:11:32Z

View all comments

See #141348 (comment).

r? @tgross35

rustbot · 2026-10-24T12:11:37Z

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

tgross35

Few things that I think make this more robust, then LGTM

View changes since this review

tgross35 · 2026-10-26T20:12:57Z

@rustbot author

Just for the CHECK-DAG, assuming it works

rustbot · 2026-10-26T20:13:07Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

tgross35 · 2026-10-27T01:23:31Z

+//@ needs-llvm-components: x86
+//@ compile-flags: --crate-type=lib -Z merge-functions=disabled -C opt-level=3 --target=x86_64-unknown-linux-gnu -C llvm-args=-x86-asm-syntax=intel
+//@ assembly-output: emit-asm


I think these should probably be reverted to how they were earlier, since needs-llvm-components: x86 does get hit even when std might not be built for x86_64-unknown-linux-gnu. (Might see this failure in CI)

View changes since the review

tgross35

Thank you!
@bors r+

View changes since this review

rust-bors · 2026-10-27T02:35:51Z

📌 Commit 808a955 has been tentatively approved by tgross35

It will be put into the queue for this repository once PR CI succeeds.

@tgross35

…ross35 Add behavior tests for `Arc` and `Rc` See <rust-lang#141348 (comment)>. r? @tgross35

Rollup of 8 pull requests Successful merges: - #164168 (Add tests for unsoundness involving alias liveness) - #164608 (core: Constify `resumable_breakpoint` and re-export it in `std`) - #164787 (cg_llvm: Use an invariant lifetime brand for LLVM contexts ) - #164851 (Add behavior tests for `Arc` and `Rc`) - #164966 (x86-64-linux-gnu seems to have working f128 now) - #153893 (Lex lifetimes as identifiers, recover from emoji and emit appropriate error) - #164895 (Disable recovery when attribute parser shouldn't emit) - #165004 (docs: Nitpick change in `HashMap`'s `.insert_entry()` doc example)

tgross35 · 2026-10-27T05:42:52Z

@bors r- #165018 (comment)

Probably should just set //@ min-llvm-version: 23 to avoid this

rust-bors · 2026-10-27T05:43:00Z

This pull request was unapproved.

This PR was contained in a rollup (#165018), which was unapproved.

View changes since this unapproval

tgross35 · 2026-10-27T07:14:17Z

@bors r+

rust-bors · 2026-10-27T07:14:21Z

📌 Commit b56bec4 has been tentatively approved by tgross35

It will be put into the queue for this repository once PR CI succeeds.

EFanZh · 2026-10-27T07:19:44Z

@bors r- #165018 (comment)

Probably should just set //@ min-llvm-version: 23 to avoid this

@tgross35: Why use 23? I only see llvm-22 in the current PR CI jobs.

tgross35 · 2026-10-27T07:25:56Z

23 is the default, just not specified. It failed with LLVM22 in the job I linked at #164851 (comment).

EFanZh · 2026-10-27T07:44:06Z

@tgross35: I suspect the failure is caused by randomize-layout, not LLVM version. The failure happens before calling handle_alloc_error, which takes a Layout argument, the registers are inverted in the failure case.

tgross35 · 2026-10-27T07:54:30Z

@bors r-

Good catch. In that case, I guess that could be disabled and LLVM22 re-enabled

rust-bors · 2026-10-27T07:54:35Z

This pull request was unapproved.

View changes since this unapproval

tgross35 · 2026-10-27T13:40:36Z

@bors try jobs=test-x86_64-gnu-llvm-22-*

Add behavior tests for `Arc` and `Rc` try-job: test-x86_64-gnu-llvm-22-*

rust-bors · 2026-10-27T14:33:43Z

💔 Test for 54f9347 failed: CI. Failed jobs:

try - test-x86_64-gnu-llvm-22-2 (web logs, enhanced plaintext logs)
try - test-x86_64-gnu-llvm-22-3 (web logs, enhanced plaintext logs)

EFanZh · 2026-10-27T14:46:00Z

Not only randomize-layout, I also see debug assertions being enabled.

EFanZh · 2026-10-27T15:08:58Z

@bors try jobs=test-x86_64-gnu-llvm-22-*

rust-bors · 2026-10-27T15:09:01Z

@EFanZh: 🔑 Insufficient privileges: not in try users

tgross35 · 2026-10-27T15:14:44Z

@bors delegate=tru

rust-bors · 2026-10-27T15:14:47Z

✌️ @tru, you can now approve this pull request!

If @tgross35 told you to "r=me" after making some further change, then please make that change and post @bors r=tgross35.

View changes since this delegation.

tgross35 · 2026-10-27T15:15:07Z

@bors delegate-
@bors delegate=try

rust-bors · 2026-10-27T15:15:10Z

✌️ @EFanZh, you can now perform try builds on this pull request!

Warning

You used the legacy format of the delegate command.
The new format is @bors delegate[=<username>] [<try|review>].

You can now post @bors try to start a try build.

rustbot assigned tgross35 Oct 24, 2026

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 24, 2026

EFanZh changed the title ~~Add behavior tests for Arc and `Rc~~ Add behavior tests for Arc and Rc Oct 24, 2026

EFanZh force-pushed the add-rc-behavior-tests branch from d4cc2de to 48c24e4 Compare October 24, 2026 12:12

EFanZh mentioned this pull request Oct 24, 2026

Make Rc<T>::deref zero-cost #141348

Open

18 tasks

EFanZh force-pushed the add-rc-behavior-tests branch 2 times, most recently from bd89710 to 71516d2 Compare October 24, 2026 14:00

EFanZh marked this pull request as ready for review October 24, 2026 16:03

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 24, 2026

tgross35 reviewed Oct 26, 2026

View reviewed changes

Comment thread tests/assembly-llvm/x86_64-rc-arc.rs

Comment thread tests/assembly-llvm/x86_64-rc-arc.rs

Comment thread tests/assembly-llvm/x86_64-rc-arc.rs

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026

EFanZh force-pushed the add-rc-behavior-tests branch from 71516d2 to 0c567bf Compare October 27, 2026 00:55

tgross35 reviewed Oct 27, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

EFanZh force-pushed the add-rc-behavior-tests branch from 0c567bf to 808a955 Compare October 27, 2026 02:34

tgross35 approved these changes Oct 27, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2026

tgross35 added a commit to tgross35/rust that referenced this pull request Oct 27, 2026

Rollup merge of rust-lang#164851 - EFanZh:add-rc-behavior-tests, r=tg…

e4c47e2

…ross35 Add behavior tests for `Arc` and `Rc` See <rust-lang#141348 (comment)>. r? @tgross35

tgross35 mentioned this pull request Oct 27, 2026

Rollup of 8 pull requests #165018

Closed

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 27, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 27, 2026

EFanZh force-pushed the add-rc-behavior-tests branch from 808a955 to b56bec4 Compare October 27, 2026 06:54

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 27, 2026

rust-bors Bot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 27, 2026

rust-bors Bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 27, 2026

Add behavior tests for Arc and Rc

74c3cca

EFanZh force-pushed the add-rc-behavior-tests branch from b56bec4 to 74c3cca Compare October 27, 2026 12:48

rust-bors Bot pushed a commit that referenced this pull request Oct 27, 2026

Auto merge of #164851 - EFanZh:add-rc-behavior-tests, r=<try>

54f9347

Add behavior tests for `Arc` and `Rc` try-job: test-x86_64-gnu-llvm-22-*

This comment has been minimized.

Sign in to view

Try to make the tests more flexible

177aab3

Conversation

EFanZh commented Oct 24, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Oct 24, 2026

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented Oct 26, 2026

Uh oh!

rustbot commented Oct 26, 2026

Uh oh!

tgross35 Oct 27, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

tgross35 commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

tgross35 commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

EFanZh commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Oct 27, 2026

Uh oh!

EFanZh commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tgross35 commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

tgross35 commented Oct 27, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors Bot commented Oct 27, 2026

Uh oh!

EFanZh commented Oct 27, 2026

Uh oh!

EFanZh commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

tgross35 commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

tgross35 commented Oct 27, 2026

Uh oh!

rust-bors Bot commented Oct 27, 2026

Uh oh!

This branch has not been deployed

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

EFanZh commented Oct 24, 2026 •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading

tgross35 Oct 27, 2026 •

edited by rustbot

Loading

tgross35 left a comment •

edited by rustbot

Loading

EFanZh commented Oct 27, 2026 •

edited

Loading

EFanZh commented Oct 27, 2026 •

edited

Loading

tgross35 commented Oct 27, 2026 •

edited

Loading