Repository navigation
handle higher-ranked preds in imperfect derives diagnostic - #164383
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
r? @TaKO8Ki rustbot has assigned @TaKO8Ki. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
r? types |
rustbot
added
the
T-types
Contributor
|
cc @raushan728 and @mejrs (author + reviewer of #159363), in case you have any thoughts. |
Contributor
|
The change looks reasonable and it needs to be backported to beta. @bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
theemathas
added
the
beta-nominated
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
…uwer Rollup of 6 pull requests Successful merges: - #164383 (handle higher-ranked preds in imperfect derives diagnostic) - #164620 (Wrap expected_ty for cfi-{diag,recover} in with_no_trimmed_paths) - #164684 (Remove redundant `PartialOrd` chaining methods) - #158076 (Offload safe mutable args with `Region` and `PartitioningStrategy`) - #164680 (Add regression test for async fn declared with #[eii]) - #164696 (Add `#[default]` for `newtype_index!`)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
Rollup merge of #164383 - sjwang05:issue-164376, r=estebank handle higher-ranked preds in imperfect derives diagnostic `trait_args` can contain escaping bound vars if we need to prove something like `for<'a> &'a T: Clone`, and since we call `skip_binder()` on `parent_trait_pred` to build the new trait ref's args, we need to rebind any bound vars we may encounter in the args. fixes #164376
github-actions Bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Oct 25, 2026
…uwer Rollup of 6 pull requests Successful merges: - rust-lang/rust#164383 (handle higher-ranked preds in imperfect derives diagnostic) - rust-lang/rust#164620 (Wrap expected_ty for cfi-{diag,recover} in with_no_trimmed_paths) - rust-lang/rust#164684 (Remove redundant `PartialOrd` chaining methods) - rust-lang/rust#158076 (Offload safe mutable args with `Region` and `PartitioningStrategy`) - rust-lang/rust#164680 (Add regression test for async fn declared with #[eii]) - rust-lang/rust#164696 (Add `#[default]` for `newtype_index!`)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trait_argscan contain escaping bound vars if we need to prove something likefor<'a> &'a T: Clone, and since we callskip_binder()onparent_trait_predto build the new trait ref's args, we need to rebind any bound vars we may encounter in the args.fixes #164376