Skip to content

feat(completion): reduce relevance for deprecated items#22085

Merged
ChayimFriedman2 merged 4 commits intorust-lang:masterfrom
ada4a:18554-float-consts
Apr 20, 2026
Merged

feat(completion): reduce relevance for deprecated items#22085
ChayimFriedman2 merged 4 commits intorust-lang:masterfrom
ada4a:18554-float-consts

Conversation

@ada4a
Copy link
Copy Markdown
Contributor

@ada4a ada4a commented Apr 18, 2026 •
edited
Loading

Fixes #18554, albeit not in a way suggested in the issue: instead of prioritising assoc items, we deprioritise suggestions that are deprecated.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 18, 2026
@ada4a
Copy link
Copy Markdown
Contributor Author

ada4a commented Apr 18, 2026

Depends on #22083, so

@rustbot blocked

@rustbot rustbot added S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2026
ada4a
ada4a commented Apr 18, 2026
View reviewed changes
Comment thread crates/ide-completion/src/item.rs Outdated
@ada4a ada4a force-pushed the 18554-float-consts branch 2 times, most recently from 924843d to 285629f Compare April 19, 2026 10:29
@ada4a
Copy link
Copy Markdown
Contributor Author

ada4a commented Apr 19, 2026

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: marked as blocked ❌ on something else such as an RFC or other implementation work. labels Apr 19, 2026
@ada4a ada4a force-pushed the 18554-float-consts branch from 285629f to c684aef Compare April 20, 2026 08:08
ChayimFriedman2
ChayimFriedman2 requested changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test that shows the score effect, like in the linked issue.

View changes since this review

Comment thread crates/ide-completion/src/item.rs Outdated
@ada4a ada4a force-pushed the 18554-float-consts branch from c684aef to 24dca9f Compare April 20, 2026 15:56
@ada4a
Copy link
Copy Markdown
Contributor Author

ada4a commented Apr 20, 2026

Please add a test that shows the score effect, like in the linked issue.

That should be render::tests::float_consts_relevance

ChayimFriedman2
ChayimFriedman2 approved these changes Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ChayimFriedman2 ChayimFriedman2 left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

View changes since this review

@ChayimFriedman2 ChayimFriedman2 added this pull request to the merge queue Apr 20, 2026
Merged via the queue into rust-lang:master with commit 4c21cec Apr 20, 2026
18 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 20, 2026
@ada4a ada4a deleted the 18554-float-consts branch April 20, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChayimFriedman2 ChayimFriedman2 ChayimFriedman2 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Should prefer associated items over a possible import with the same name

3 participants

@ada4a @ChayimFriedman2 @rustbot