fix: deduplicate warnings lint in completion#22059
Closed
JasmineLCY wants to merge 1 commit intorust-lang:masterfrom
Closed
fix: deduplicate warnings lint in completion#22059JasmineLCY wants to merge 1 commit intorust-lang:masterfrom
warnings lint in completion#22059JasmineLCY wants to merge 1 commit intorust-lang:masterfrom
Conversation
The `warnings` lint appeared in both individual lints and lint groups, causing it to show up twice in completions. Skip `warnings` when adding lint groups to `DEFAULT_LINTS`, matching the existing skip in `DEFAULT_LINT_GROUPS`. Closes rust-lang#21943
rustbot
added
the
S-waiting-on-review
Collaborator
|
Collaborator
|
☔ The latest upstream changes (possibly #22054) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
Closing this as #22054 has fixed the related issue and it was opened before this and is a bit more desirable fix |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
warningslint appeared twice in completions because it exists as both an individual lint and a lint group. The codegen already skipswarningswhen buildingDEFAULT_LINT_GROUPS, but was missing the same skip when adding lint groups toDEFAULT_LINTS.This adds the same
if name == "warnings" { continue; }guard to the lint-groups-to-DEFAULT_LINTSloop, matching the existing pattern forDEFAULT_LINT_GROUPS.Closes #21943.
Drafted with AI assistance, reviewed and tested by me.