start storing peak-memory-usage in builds table#3299
Open
syphar wants to merge 1 commit intorust-lang:mainfrom
Open
start storing peak-memory-usage in builds table#3299syphar wants to merge 1 commit intorust-lang:mainfrom
syphar wants to merge 1 commit intorust-lang:mainfrom
Conversation
github-actions
bot
added
the
S-waiting-on-review
syphar
changed the title
syphar
changed the title
syphar
commented
Apr 16, 2026
| use tracing::{debug, error, info, info_span, instrument, warn}; | ||
|
|
||
| #[derive(Default)] | ||
| struct ProcessStatistics(RustwideProcessStats); |
Member
Author
There was a problem hiding this comment.
we could get rid of this NewType with rust-lang/rustwide#122
Member
There was a problem hiding this comment.
Maybe we should do that first? Lot of trait impls for conversions.
Member
Author
There was a problem hiding this comment.
this is not critical, if you agree that this has a place in rustwide, we should do that :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for now it's just the max of all sub-builds (all targets, json builds), I think that is what we and the authors would need most of the time.
Theoretically we could emit log entries with more details, but I want to think about that longer.
Use case for us and authors is mostly to be able to judge what memory limit is needed in the sandboxes.
First just store, then we look at it, UI later.