Skip to content

close default kcfg minimization 4 cse #885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Stevengre wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

close default kcfg minimization 4 cse #885

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
da9e0d6
don't minimize proof during cse; close minimize_proof for SUMMARY_CON…
Stevengre Nov 18, 2024
e4abf8e
select some tests with external calls for testing the `--cse` option.
Stevengre Nov 18, 2024
ca4fc5f
provide basic cse test without minimization
Stevengre Nov 19, 2024
2af2b1f
fix 4 `make format` and `make check`
Stevengre Nov 19, 2024
29aa84e
skip some test that cannot generate rules
Stevengre Nov 19, 2024
93defae
update expected ouput
Stevengre Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/kontrol/prove.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ def create_kcfg_explore() -> KCFGExplore:
if progress is not None and task is not None:
progress.update(task, advance=1, status='Finished')

if options.minimize_proofs or options.config_type == ConfigType.SUMMARY_CONFIG:
if options.minimize_proofs:

@Stevengre Stevengre Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close default minimize_proofs for SUMMARY_CONFIG.

proof.minimize_kcfg()

if start_time is not None:
Expand Down
5 changes: 5 additions & 0 deletions src/tests/integration/test-data/foundry-cse
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
AssertTest.test_assert_false()

@palinatolmach palinatolmach Nov 18, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this file used for? I think foundry-dependency-* stores the test function names for CSE tests.

@Stevengre Stevengre Nov 19, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted

AssertTest.testFail_expect_revert()
AssertTest.test_failing_branch(uint256)
AssertTest.test_revert_branch(uint256,uint256)
MergeKCFGTest.test_branch_merge(uint256,uint256,bool)