Conversation
anvacaru
marked this pull request as ready for review
July 27, 2026 09:44
palinatolmach
self-requested a review
August 27, 2026 11:25
palinatolmach
approved these changes
Aug 27, 2026
| andBool TX_MAX_PRIORITY_FEE <=Int TX_MAX_FEE | ||
| andBool BAL >=Int TX_GAS_LIMIT *Int TX_MAX_FEE +Int VALUE | ||
| andBool TX_GAS_LIMIT <=Int BLOCK_GAS_LIMIT | ||
| andBool (notBool Ghastxgaslimit << SCHED >> orBool TX_GAS_LIMIT <=Int Gmaxtxgaslimit < SCHED >) |
Member
There was a problem hiding this comment.
This could be extracted into a helper looking something like this, but I think as is it's fine too:
syntax Bool ::= #hasValidTxGasLimit ( Int , Schedule ) [symbol(#hasValidTxGasLimit), function]
// ------------------------------------------------------------------------------------------------
rule #hasValidTxGasLimit(TX_GAS_LIMIT, SCHED) => notBool Ghastxgaslimit << SCHED >> orBool TX_GAS_LIMIT <=Int Gmaxtxgaslimit < SCHED >
palinatolmach
left a comment
palinatolmach
left a comment
Member
There was a problem hiding this comment.
One more thing: the description of #isValidTransaction(TXID, SENDER) in state-utils.md could be updated to include the new transaction gas limit checking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding a check in
#isValidTransactionrules to check that the transaction gas limit is below the cap in schedules where EIP-7825 is active.