Skip to content

Add simplification to mcd-structured verification module #2828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
automergerpr-permission-manager merged 2 commits into from
Dec 15, 2025
Merged

Add simplification to mcd-structured verification module #2828

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d00b4e7
add simplification to mcd-structured verification module (buf ==K nul…
jberthold Dec 12, 2025
4f7c716
Merge branch 'master' into simplify-mcd-structured-proofs-rebased
anvacaru Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions tests/specs/mcd-structured/verification.k
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,4 +401,11 @@ module LEMMAS-MCD [symbolic]
rule #if B #then C #else D #fi => C requires B [simplification]
rule #if B #then C #else D #fi => C requires notBool B [simplification]

// #buf simplification comparing to null-bytes: compare as Int
rule #buf(N, X:Int) ==K NULLBYTES => X ==Int 0
requires 0 <=Int X
andBool X <=Int 2 ^Int ( 8 *Int N)
andBool #asInteger(NULLBYTES) ==Int 0
[simplification, concrete(NULLBYTES)]
Comment on lines +404 to +409

@ehildenb ehildenb Dec 15, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jberthold shouldn't this be X <Int 2 ^Int (8 *Int N), not <=Int?

@jberthold jberthold Dec 15, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, should be <Int, sorry for that. I'll make a PR to correct it.

@jberthold jberthold Dec 15, 2025

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, we would also want length(NULLBYTES) ==Int N (and 0 <=Int N but that's implied by the former), as well as preserves-definedness.


endmodule