log-adviser: bump commit, plugin now makes no network requests#12011
Merged
riktenx merged 1 commit intoMay 18, 2026
Conversation
The plugin now makes zero network requests. Both the TempleOSRS collection-log fetch and the secure.runescape.com Hiscores fetch have been removed; all data is bundled and progress is tracked from in-game events only. The previous third-party warning therefore no longer applies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
runelite-github-app
Bot
added
plugin change
size-m
warning change
|
Plugin warning has changed
|
|
This plugin requires reviews from Plugin Hub reviewers. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the merged Log Adviser submission, replacing #12010.
In review, @riktenx added a
warning=line because the plugin fetched the player's collection log from TempleOSRS (a third-party server).The plugin has since been changed to make zero network requests at all:
TempleOsrsClient(TempleOSRS collection-log fetch) — removedHiscoreRankFetcher(thesecure.runescape.comHiscores fetch) — also removed, along with the sidebar rank / slots-logged display that depended on itAll data now ships bundled with the plugin, and collection-log progress is tracked purely from in-game events (the "new item" chat message and the collection-log widget). Nothing is sent anywhere.
New plugin commit:
SFranciscoSouza/LogAdviser@22e5be5This PR:
commit=to22e5be5e94569dae8c83252679c54a349b139d20warning=line, which no longer applies (no third-party — or any — network access)🤖 Generated with Claude Code